[internal] Switch to go hooks and images build refactoring #43
Conversation
Signed-off-by: v.oleynikov <[email protected]>
duckhawk
force-pushed
the
change-python-hooks-to-go-and-modules-refactoring
branch
from
fdd52c4 to
6d3b4ef
Compare
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
| fmt.Sprintf("%s.%s", consts.WEBHOOKS_CERT_CN, consts.MODULE_NAMESPACE), | ||
| fmt.Sprintf("%s.%s.svc", consts.WEBHOOKS_CERT_CN, consts.MODULE_NAMESPACE), | ||
| // %CLUSTER_DOMAIN%:// is a special value to generate SAN like 'svc_name.svc_namespace.svc.cluster.local' | ||
| fmt.Sprintf("%%CLUSTER_DOMAIN%%://%s.%s.svc", consts.WEBHOOKS_CERT_CN, consts.MODULE_NAMESPACE), |
There was a problem hiding this comment.
From what I see here, it is literally %CLUSTER_DOMAIN%:// (single percent sign)
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| func NewKubeClient() (client.Client, error) { |
There was a problem hiding this comment.
Duplicate of hooks/go/050-migrate-auth-to-connection/migrate-auth-to-connection.go, let's move to common place
|
|
||
| cl, err := NewKubeClient() | ||
| if err != nil { | ||
| fmt.Printf("%s", err.Error()) |
There was a problem hiding this comment.
Since we're using fmt.Printf for logging, each log line should end with a newline. Error text normally don't end on a newline. Please fix it in every place. Better approach would be to use logger from pkg.HookInput
Also, there's no need to call .Error(), formatter will call it byitself, if you just pass err
| err = cl.Patch(ctx, &secret, patch) | ||
| if err != nil { | ||
| fmt.Printf("[remove-sc-and-secrets-on-module-delete]: Failed to patch secret %s: %v", secret.Name, err) | ||
| continue |
There was a problem hiding this comment.
continue looses errors. Instead, we should collect them, e.g.: resultErr := errors.Join(resultErr, err), and check resultErr in the end. The same for ConfigMap loop, and for StorageClassList loop below.
| } | ||
|
|
||
| fmt.Printf("[remove-sc-and-secrets-on-module-delete]: Removing %s storage class\n", sc.Name) | ||
| err = cl.Delete(ctx, &storagev1.StorageClass{ |
There was a problem hiding this comment.
Why no just cl.Delete(ctx, &sc)? I'm not sure if deletion with just Name will work at all.
| tls.key: {{ .Values.csiCeph.internal.customWebhookCert.key }} | ||
| ca.crt: {{ .Values.csiCeph.internal.customWebhookCert.ca | b64enc | quote }} | ||
| tls.crt: {{ .Values.csiCeph.internal.customWebhookCert.crt | b64enc | quote }} | ||
| tls.key: {{ .Values.csiCeph.internal.customWebhookCert.key | b64enc | quote }} |
There was a problem hiding this comment.
Why? Isn't it going to break the code, which uses that cert from secret? Or the code is already broken and you're fixing it?
Description
We need to switch to go module hooks, and get correct package names in internal packages
What is the expected result?
Correct module structure and hooks
Checklist