fix: remove stale NonceTooLow txs from retry loop#210
Merged
qj0r9j0vc2 merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecutionResultProblem
After block execution,
retry_pending()re-sends all unexecuted pending transactions to the Worker channel for rebatching. However, NonceTooLow transactions can never succeed (their nonce has already been used), so they cycle forever: Worker → Batch → Consensus → Execution (NonceTooLow) → retry → Worker → ...This produces blocks where all transactions are skipped, wasting consensus bandwidth and producing empty blocks.
Changes
ExecutionResult.skipped_tx_hashes— new field tracking NonceTooLow tx hashesengine.rs— collects skipped hashes duringprocess_transactionsBlockExecutionResult— propagates skipped hashes through execution bridgenode.rs— removes skipped txs from pending map and excludes from retryTest plan
cargo checkpassescargo test -p cipherbft-execution -p cipherdpasses