DBZ-8340 Update GTID set also for TX payload events #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currnet test compares GTID from two different clients which actually doesn't ensure that GTID is chaning on the same client. Fix the to always compare GTID changes on the same client.
CountDownEventListener is used in many tests for waiting for events in the DB. As it's based on the event type, it doesn't work for compressed binlog, when events are `TRANSACTION_PAYLOAD` events. To be able to run the tests also with compressed binlog without any major rewrite, support `TRANSACTION_PAYLOAD` data in this helper class and process all events contained in `TRANSACTION_PAYLOAD` event. Similar to `CapturingEventListener`.
Tests which don't work with compressed binlog are skipped.
When binlog compression is enabled, events are wrapped inside `TRANSACTION_PAYLOAD` events and thus GTID set is never updated. This may cause replay of events when the client thread in interrupted and started again by keep-alive thread as the new client would start from the original (initial) GTID set. Updateing GTID set also for `TRANSACTION_PAYLOAD` events ensures that GTID set is update also when binlog compression is enabled.
|
Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-8340