Skip to content

Commit

Permalink
Merge branch 'dev'
Browse files Browse the repository at this point in the history
  • Loading branch information
ddnexus committed Apr 2, 2024
2 parents 56ad22f + 1085b52 commit d44b81c
Show file tree
Hide file tree
Showing 178 changed files with 8,816 additions and 5,610 deletions.
2 changes: 0 additions & 2 deletions .github/.env

This file was deleted.

79 changes: 39 additions & 40 deletions .github/ISSUE_TEMPLATE/Code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,32 +7,19 @@ body:
- type: markdown
attributes:
value: >
Thanks for taking the time to fill out this bug report!
### IMPORTANT
_Code Issues are reserved for real, reproducible pagy bugs.
If you are not sure that your problem is a bug, please ask for solutions in the
[Q&A](https://github.com/ddnexus/pagy/discussions/categories/q-a) support area._
### PREREQUISITE
**We need running code to reproduce the problem with a single click or command!**
Please, understand that we cannot write the code that fails for you,
so ONLY pick and provide your preferred support from the list below...
### Thank you for your bug report!
Please, understand that code issues are reserved for real, reproducible pagy bugs.
_If you are not sure that your problem is actually a bug,
please ask for [support](https://github.com/ddnexus/pagy/discussions/categories/q-a) instead._
- type: checkboxes
id: prereq
attributes:
label: Before submitting...
options:
- label: I upgraded to the latest version of pagy
- label: I upgraded to pagy version 8.0.0
required: true
- label: I searched through the [Documentation](https://ddnexus.github.io/pagy/)
required: true
Expand All @@ -41,34 +28,46 @@ body:
- label: I searched through the [Q&A](https://github.com/ddnexus/pagy/discussions/categories/q-a)
required: true

- type: markdown
attributes:
value: >
### IMPORTANT!
**The issue MUST provide a code file confirming the bug AND complying with the list below
OR it will be automatically closed!**
#### Valid code files
- Edited copy of a single-file APP from the [Pagy Playground](https://ddnexus.github.io/pagy/playground)
- Link to a pagy fork containing an added test file
- A plain ruby file that can run as a single command `ruby issue_123.rb`
_(without any other setup step, installation or guessing, and with no or minimal interaction required)_
_If anything is unclear to you, please ask for [support](https://github.com/ddnexus/pagy/discussions/categories/q-a).
We will be happy to help._
- type: checkboxes
id: support
attributes:
label: I am providing...
description: |
...at least one of the following code supports reproducing the issue:
label: REQUIREMENTS
options:
- label: >
Simple snippet that would work **"as-is" in vanilla IRB (no rails console) without invoking
any external/non-pagy code or gem!** (You may find the
[Pagy::Console](https://ddnexus.github.io/pagy/docs/api/console) helpful)
- label: Plain ruby file that can run as `ruby my-problem.rb`
- label: >
Edited copy of the single file
[pagy_standalone.ru](https://github.com/ddnexus/pagy/blob/master/apps/pagy_standalone.ru)
- label: >
Edited copy of the single file
[pagy_bare_rails.rb](https://github.com/ddnexus/pagy/blob/master/apps/pagy_bare_rails.rb)
- label: Link of my own branch forked from pagy, which contains an added test file
- label: >
Link of my own branch forked from
[any of the rails apps listed here.](https://github.com/stars/benkoshy/lists/rails-demo-apps-for-pagy)
- label: A `docker-compose` file that uses only docker images and no local context and runs with `docker-compose up`
- label: I am providing a code file that confirms the bug
required: true
- label: I am aware that this issue will be automatically closed if the code file is missing or invalid
required: true

- type: textarea
id: description
attributes:
label: Description
placeholder: Please, describe the issue...
placeholder: >
1. Describe what actually happens
2. Describe what should happen instead
validations:
required: true
12 changes: 12 additions & 0 deletions .github/latest_release_body.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
## ⚠ WARNING

We may drop pagy's less used CSS extras.

If you wish to keep your favorites alive, please, [vote here](https://github.com/ddnexus/pagy/discussions/categories/survey)

### ✴ What's new in 8.0.0 ✴

- Better frontend helpers
- New [Pagy Playground](https://ddnexus.github.io/pagy/playground/) to showcase, clone and develop pagy APPs without any setup on
your side (try the [pagy demo](https://ddnexus.github.io/pagy/playground.md#3-demo-app))
- See the [Changelog](https://ddnexus.github.io/pagy/changelog) for possible breaking changes
28 changes: 28 additions & 0 deletions .github/workflows/create-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Create Release

on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+"

jobs:
build:
name: Create Release
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/[email protected]
- name: Create Release
id: create_release
uses: comnoco/[email protected]
env:
# This token is provided by Actions, you do not need to create your own token
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref_name }}
release_name: Version ${{ github.ref_name }}
body_path: .github/latest_release_body.md
draft: false
prerelease: false
owner: ddnexus
repo: pagy
6 changes: 3 additions & 3 deletions .idea/runConfigurations/Calendar.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions .idea/runConfigurations/Rails.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions .idea/runConfigurations/Repro.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ AllCops:
# "Unable to find gem panolint; is the gem installed? Gem::MissingSpecError" in all ruby versions
- vendor/bundle/**/*
- pnpm/**/*
- lib/optimist.rb

Layout/LineLength:
Max: 130
Expand All @@ -29,6 +30,7 @@ Layout/ExtraSpacing:
Enabled: true
Exclude:
- test/**/*
- lib/bin/pagy

Layout/EmptyLines:
Exclude:
Expand All @@ -53,6 +55,9 @@ Metrics:
Naming/VariableNumber:
CheckSymbols: false

Naming/MethodParameterName:
Enabled: false

# not cool
Style/CommentedKeyword:
Enabled: false
Expand All @@ -61,6 +66,7 @@ Style/EmptyCaseCondition:
Style/LambdaCall:
Enabled: false


# cannot inline the disabling in the file because rubocop complains anyway
Style/RedundantInitialize:
Exclude:
Expand Down
Loading

0 comments on commit d44b81c

Please sign in to comment.