-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typing on search/match/findall/sub/... #5
Conversation
A good thing on Python typing is that even original package doesn't have typing, you can still use typing stub. If you do not want to maintain this package I can keep maintaining it. re2 looks pretty stable so I guess we won't need to change this package very much. I know nothing about gerrit or bazel, it will take me lots of time to |
Sorry for the delay, I'll review this PR soon. |
c456cd1
to
f3460d7
Compare
Thanks! I learned a lot more about constrained types. I just had some style issues. And to speed up convergence, I just applied my suggestions to your PR. Let me know if you have any objections by Tuesday end (anywhere on earth "timezone"); otherwise, I'll merge the PR as it is and prepare a new PyPI release with these changes. |
LGTM. sadly we can't export |
new pypi release? |
Done! |
you can run
mypy tests
andpython tests/api/__init__.py
to verify typing are both valid at runtime and typing level.this should suppress #4 , patch are included in this PR.