Repository navigation
fix: install sqlsrv and pdo_sqlsrv with separate pecl commands - #58
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
pecl install a bexits 0 when only one of the packages fails, so the PHP 8.1 and 8.2 builds passed withpdo_sqlsrvmissing. This installs each extension with a separatepecl install, so any failure stops the build.The Issue
PHP 7.4 and 8.0 failed at
ddev restart, as expected. PHP 8.1 and 8.2 built fine and only failed onassert_line "pdo_sqlsrv", becausesqlsrvwas installed andpdo_sqlsrvwasn't. PEAR only returns an error when none of the requested packages could be downloaded, seedoInstall()inPEAR/Command/Install.php.How This PR Solves The Issue
sqlsrvandpdo_sqlsrvare installed with twopecl installcommands, soset -ecatches a failure in either of them.This doesn't work around php/web-pecl#119. PHP 7.0-8.2 tests will keep failing until it's fixed on the pecl.php.net side.
Manual Testing Instructions
Automated Testing Overview
No new tests. The existing
php70-php73andphp74-php82tests cover the PECL install.Release/Deployment Notes
None.
🤖 Generated with Claude Code