Skip to content

feat: depend on ddev/ddev-solr, fixes #40 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

mkalkbrenner
Copy link
Collaborator

@mkalkbrenner mkalkbrenner commented May 8, 2024

The Issue

How This PR Solves The Issue

TODO:

  • depend on ddev/ddev-solr
  • migrate existing core
  • add drupal-specific stuff to ddev/ddev-solr
  • README
  • tests

Manual Testing Instructions

ddev add-on get ddev/ddev-solr
ddev add-on get https://github.com/ddev/ddev-drupal-solr/tarball/ddev-solr
ddev restart

Automated Testing Overview

Release/Deployment Notes

@mkalkbrenner mkalkbrenner marked this pull request as draft May 8, 2024 17:12
@mkalkbrenner
Copy link
Collaborator Author

@rfay @bserem @tyler36
Before I continue to work on the todos, it would be great to get some feedback or thoughts on this approach and the direction outlined in #40

@bserem
Copy link
Collaborator

bserem commented May 14, 2024

@mkalkbrenner as I understand end-users will have to install both addons, and that's it more or less. Or perhaps we can add the dependency in the pre_install_actions (not sure if this is possible).

The PR definitely makes things cleaner, but it also makes me wonder:
is this addon needed after the migration has happened?

@mkalkbrenner
Copy link
Collaborator Author

mkalkbrenner commented May 14, 2024

The dependency is already declared in install.yaml.

And yes, I think we should keep both modules. All drupal-specific stuff should be moved here:

  • documentation
  • commands to install/deploy ...
    • jump-start configset
    • fresh generated configset
    • Solr hosters' drupal-specific configsets
  • multisite search
  • support for search_api_solr_nlp
  • ...

This way dev-solr will have no relation to drupal anymore and could be the base for ddev-typo3-solr, too.

@stasadev stasadev changed the title ddev-solr feat: depend on ddev/ddev-solr, fixes #40 Apr 24, 2025
@stasadev
Copy link
Member

Rebased and resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants