-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: depend on ddev/ddev-solr
, fixes #40
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mkalkbrenner as I understand end-users will have to install both addons, and that's it more or less. Or perhaps we can add the dependency in the The PR definitely makes things cleaner, but it also makes me wonder: |
The dependency is already declared in install.yaml. And yes, I think we should keep both modules. All drupal-specific stuff should be moved here:
This way dev-solr will have no relation to drupal anymore and could be the base for ddev-typo3-solr, too. |
Rebased and resolved conflicts. |
The Issue
How This PR Solves The Issue
TODO:
Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes