Fix cargo error in bit-set crate by implementing own minimal BitSet #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzazKamaz
changed the title
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that newest cargo is not building libusb-rs because it depends on bit-set v0.2.0 that has incorrect Cargo.toml file (dependency without version). Also found pr #15 that have failed building on rust v1.3 because of bit-set update.
So I have written little implementation of bitset (with tests) that is enough for libusb usage. It's even a bit faster than old one (benchmarked with criterion: https://gist.github.com/AzazKamaz/71c0ff5277033ece07f33b70848c309f)