Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows upgrade and testing [WIP] #102

Merged
merged 9 commits into from
Mar 26, 2020
Merged

Windows upgrade and testing [WIP] #102

merged 9 commits into from
Mar 26, 2020

Conversation

fatz
Copy link
Contributor

@fatz fatz commented Mar 13, 2020

fixes #101

  • added update tests
  • wrong variable used
  • facts are missing

Including facts does not work yet

@fatz fatz mentioned this pull request Mar 24, 2020
Closed
@janisz
Copy link
Contributor

janisz commented Mar 25, 2020

flaky ansible tests where related to spot instance capacity. As ansible is not able to give a spot block time and the capacity seems to be pretty low. AWS kills some of our test instances from time to time in the middle of a test.

This gives us pretty weird errors as ansible tasks time out or a first taks running fine and a second one throws SSH timeout.

The current workaround is deactivating spot usage. But we need to investigate how to let ansible use spot block so we can request spot instances with a minimum running time
https://mesosphere.slack.com/archives/CHPEMR8VA/p1585156668020900?thread_ts=1585156668.020900&cid=CHPEMR8VA

sergiimatusEPAM
sergiimatusEPAM reviewed Mar 25, 2020
View reviewed changes
roles/dcos_agent_windows/tasks/main.yml Outdated
@@ -8,23 +13,27 @@
path: '{{ base_windows_dir }}\etc\dcos-version.json'
register: previous_installation

- name: Windows | Create dcos_installation.fact.ps1
win_copy:
content: get-content {{ base_windows_dir }}\etc\ansible\facts.d\dcos_installation.fact -Raw | ConvertFrom-Json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content of dcos_installaton.fact file will be available after task "Copy dcos-version.json to fact directory" . Therefore I don't recommend line 16 .. 22 to be added with anything

@fatz fatz force-pushed the pr-101/OleksandrBielov/feature/windows branch from da23f05 to 21bfd97 Compare March 26, 2020 06:43
@fatz fatz force-pushed the pr-101/OleksandrBielov/feature/windows branch from 21bfd97 to 8d1716f Compare March 26, 2020 06:45
@fatz
Copy link
Contributor Author

fatz commented Mar 26, 2020

as this deactivates spot instance usage I've created #107 tracking this as a bug

@fatz fatz merged commit 9fbe95f into feature/windows Mar 26, 2020
@fatz fatz deleted the pr-101/OleksandrBielov/feature/windows branch March 26, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiimatusEPAM sergiimatusEPAM sergiimatusEPAM left review comments

@janisz janisz janisz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fatz @janisz @sergiimatusEPAM @OleksandrBielov