Skip to content

Update not_null_proportion.sql to handle function in group_by_columns #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update not_null_proportion.sql to handle function in group_by_columns #976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f93c5a
Update not_null_proportion.sql to handle function in group_by_columns
chaubilly Dec 30, 2024
9ef9693
Update not_null_proportion.sql
chaubilly Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions macros/generic_tests/not_null_proportion.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
{% set at_most = kwargs.get('at_most', kwargs.get('arg', 1)) %}

{% if group_by_columns|length() > 0 %}
{% set select_gb_cols = group_by_columns|join(' ,') + ', ' %}
{% set select_gb_cols = group_by_columns|join(' ,') + ' as _group, ' %}
{% set groupby_gb_cols = 'group by ' + group_by_columns|join(',') %}
{% endif %}

Expand All @@ -22,7 +22,7 @@ with validation as (
),
validation_errors as (
select
{{select_gb_cols}}
{% if group_by_columns|length() > 0 %}_group,{% endif %}
not_null_proportion
from validation
where not_null_proportion < {{ at_least }} or not_null_proportion > {{ at_most }}
Expand Down
Loading