Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1185: Separate serial integration tests #752

Draft
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

VanTudor
Copy link
Contributor

Problem

We don't have a cookie cutter way of running flaky tests in series.

Solution

This PR makes all tests that are tagged with @pytest.mark.serial run in series. They are scoped per adapter. For example, given the athena and redshift adapters, we could have one athena and one redshift serial tests running at a given time,
but no more than one per adapter.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VanTudor VanTudor requested a review from a team as a code owner January 28, 2025 12:14
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Jan 28, 2025
@VanTudor VanTudor marked this pull request as draft January 28, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants