Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up check for illegal top-level op #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larryl
Copy link

@larryl larryl commented May 18, 2021

Calling List::Util::first here keeps showing up as a hotspot on our NYTProf output, so just use a regex instead.

Calling List::Util::first here keeps showing up as a hotspot on our NYTProf output, so just use a regex instead.
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #21 (85eb1ba) into master (7bed2f6) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 85eb1ba differs from pull request most recent head 8d3d33c. Consider uploading reports for the commit 8d3d33c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   74.57%   74.53%   -0.04%     
==========================================
  Files           7        7              
  Lines        1341     1339       -2     
  Branches      384      384              
==========================================
- Hits         1000      998       -2     
  Misses        252      252              
  Partials       89       89              
Impacted Files Coverage Δ
lib/SQL/Abstract.pm 73.09% <ø> (-0.04%) ⬇️
lib/SQL/Abstract/Test.pm 71.42% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bed2f6...8d3d33c. Read the comment docs.

@coveralls
Copy link

coveralls commented May 18, 2021

Pull Request Test Coverage Report for Build 76

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.791%

Totals Coverage Status
Change from base Build 73: -0.02%
Covered Lines: 1022
Relevant Lines: 1265

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants