Add latest version combination #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought I'd start a small attempt at fixing dbkaplan#56.
Author
|
Hmm… It doesn't seem like an inspection is triggered. Maybe it's because I created a draft request. |
Author
|
I don't know how valuable DRF 3.7 and 3.8 are to include, so I'm leaving those out for now. |
Author
|
There are a lot of build jobs now, so I think I'll refrain from adding more unless anyone expresses interest. Cool to see that everything works even on Django 2.2 😀 |
|
To me, the most important part of this PR is testing with the latest everything: Python 3.7, Django 2.2 (LTS), and DRF 3.9. Thanks! |
johnthagen
suggested changes
Jul 7, 2019
johnthagen
left a comment
johnthagen
left a comment
There was a problem hiding this comment.
I'd suggest also updating setup.py classifiers to add Python 3.7.
johnthagen
reviewed
Jul 7, 2019
johnthagen
left a comment
johnthagen
left a comment
There was a problem hiding this comment.
It'd be helpful to update the supported versions section of the README as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I'd start a small attempt at fixing #56.