Skip to content

make the decorators work with both @classmethod and @staticmethod #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make the decorators work with both @classmethod and @staticmethod #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions dry_rest_permissions/generics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
permission checks to be returned by the api per object so that
they can be consumed by a front end application.
"""
import inspect
from functools import wraps

from rest_framework import filters
Expand Down Expand Up @@ -271,14 +272,14 @@ def allow_staff_or_superuser(func):
This decorator is used to abstract common is_staff and is_superuser functionality
out of permission checks. It determines which parameter is the request based on name.
"""
is_object_permission = "has_object" in func.__name__
is_method = inspect.ismethod(func)

@wraps(func)
def func_wrapper(*args, **kwargs):
request = args[0]
# use second parameter if object permission
if is_object_permission:
if is_method is True:
request = args[1]
else:
request = args[0]

if request.user.is_staff or request.user.is_superuser:
return True
Expand All @@ -293,14 +294,14 @@ def authenticated_users(func):
This decorator is used to abstract common authentication checking functionality
out of permission checks. It determines which parameter is the request based on name.
"""
is_object_permission = "has_object" in func.__name__
is_method = inspect.ismethod(func)

@wraps(func)
def func_wrapper(*args, **kwargs):
request = args[0]
# use second parameter if object permission
if is_object_permission:
if is_method is True:
request = args[1]
else:
request = args[0]

if not(request.user and request.user.is_authenticated):
return False
Expand All @@ -315,14 +316,14 @@ def unauthenticated_users(func):
This decorator is used to abstract common unauthentication checking functionality
out of permission checks. It determines which parameter is the request based on name.
"""
is_object_permission = "has_object" in func.__name__
is_method = inspect.ismethod(func)

@wraps(func)
def func_wrapper(*args, **kwargs):
request = args[0]
# use second parameter if object permission
if is_object_permission:
if is_method is True:
request = args[1]
else:
request = args[0]

if request.user and request.user.is_authenticated:
return False
Expand Down