Skip to content

Conversation

@rlaiola
Copy link
Contributor

@rlaiola rlaiola commented Dec 9, 2025

Reference issue

None

What does this implement/fix?

This PR skips an incomplete and non-functional SQL dump parsing test, and it fixes and brings back another test that was not being executed.

Background

The codebase contains grammar rules for parsing SQL dump syntax (CREATE TABLE / INSERT INTO statements via the 'dbDumpStart' entry point in grammar_sql.pegjs), but this feature does not seem to have been fully implemented or integrated into the main parser flow.

Changes

  • Skipped the incomplete test module 'translate sql dump to group definition' which contained only a single test (dbdump 1)
  • Renamed the next tests to 'translate sql ast to relational algebra'.

Testing

All remaining SQL translation tests continue to pass. No functional changes to the actual parser or translator logic.

Before (https://dbis-uibk.github.io/relax/test.html):

Screenshot 2025-12-09 at 09 00 38

After (http://localhost:8088/test.html):

Screenshot 2025-12-09 at 09 00 25

Future Work

If SQL dump parsing support is desired in the future, the following would be required:

  • Implement convertSqlDumpToRelalg();
  • Wire dbDumpStart into the main parser with auto-detection logic;
  • Add comprehensive tests for CREATE TABLE, INSERT INTO, and multi-table dumps;
  • Document the feature and expose it in the public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant