Fix SQL dump parsing test #271
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
None
What does this implement/fix?
This PR skips an incomplete and non-functional SQL dump parsing test, and it fixes and brings back another test that was not being executed.
Background
The codebase contains grammar rules for parsing SQL dump syntax (
CREATE TABLE/INSERT INTOstatements via the 'dbDumpStart' entry point ingrammar_sql.pegjs), but this feature does not seem to have been fully implemented or integrated into the main parser flow.Changes
dbdump 1)Testing
All remaining SQL translation tests continue to pass. No functional changes to the actual parser or translator logic.
Before (https://dbis-uibk.github.io/relax/test.html):
After (http://localhost:8088/test.html):
Future Work
If SQL dump parsing support is desired in the future, the following would be required:
convertSqlDumpToRelalg();dbDumpStartinto the main parser with auto-detection logic;CREATE TABLE,INSERT INTO, and multi-table dumps;