support ruby 3.1 and keep old versions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know about #10. Difference is that my version keeps support for old versions as well |
|
@dball Please merge this. This PR will make this gem support newer versions of ruby. |
haseebeqx
approved these changes
Apr 8, 2023
|
I need this PR merged. Can someone please merge it? I get the following error without this fix. NameError: uninitialized class variable @@schemes in URI
/Users/ash/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/data_uri-0.1.0/lib/data_uri/uri.rb:64:in `<module:URI>' |
wqsaali
approved these changes
Sep 9, 2024
will-clarke-blacklane
pushed a commit
to will-clarke-blacklane/data_uri
that referenced
this pull request
Nov 8, 2024
|
Planning to release a new gem with similar name just to let people use it with newer uri versions (required by rails 8) |
|
Released a beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.