Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use mitosis attribute passing for angular and stencil #3751

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: use mitosis attribute passing for angular and stencil #3751

wants to merge 2 commits into from
+12 −90

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Jan 30, 2025

Proposed changes

New Mitosis version included customAttributePassing for angular and stencil, which we used as workaround

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) January 30, 2025 15:06
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/chore-mitosis-attribute-passing

@github-actions github-actions bot added the 🏘components Changes inside components folder label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke