Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: component properties for alpha components #3713

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

refactor: component properties for alpha components #3713

wants to merge 10 commits into from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Jan 21, 2025

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget marked this pull request as draft January 21, 2025 12:48
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-component-properties

@nmerget
fix: build issue
06fc6cb
@nmerget
chore: update snapshots
9432666
@nmerget
Merge remote-tracking branch 'origin/main' into refactor-component-pr…
e7283ff 
…operties

# Conflicts:
#	__snapshots__/popover/component/chromium/DBPopover-after-open-should-match-screenshot.png
#	__snapshots__/popover/component/firefox/DBPopover-after-open-should-match-screenshot.png
#	__snapshots__/popover/component/mobile-chrome/DBPopover-after-open-should-match-screenshot.png
#	__snapshots__/tooltip/component/chromium/DBTooltip-after-open-should-match-screenshot.png
#	__snapshots__/tooltip/component/firefox/DBTooltip-after-open-should-match-screenshot.png
#	__snapshots__/tooltip/component/mobile-chrome/DBTooltip-after-open-should-match-screenshot.png
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Jan 22, 2025
@nmerget nmerget marked this pull request as ready for review January 31, 2025 08:26
@nmerget nmerget added this to the Stable Release milestone Jan 31, 2025
@nmerget nmerget marked this pull request as draft February 3, 2025 13:45
@mfranzke mfranzke assigned mfranzke and unassigned mfranzke Feb 3, 2025
@nmerget
Merge branch 'main' into refactor-component-properties
1d2e7ee 
# Conflicts:
#	__snapshots__/accordion-item/patternhub/accordion-item-overview-should-match-screenshot.png
#	__snapshots__/accordion/patternhub/accordion-overview-should-match-screenshot.png
#	__snapshots__/navigation-item/patternhub/navigation-item-overview-should-match-screenshot.png
#	__snapshots__/tabs/showcase/chromium-highContrast/DBTabs-should-match-screenshot-1/DBTabs-should-match-screenshot.png
#	packages/components/src/components/tabs/tabs.lite.tsx
@nmerget nmerget marked this pull request as ready for review February 4, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
Stable Release
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke