Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid text color for inputs #3539

Merged
merged 6 commits into from
Dec 2, 2024
Merged

fix: invalid text color for inputs #3539

merged 6 commits into from
Dec 2, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 1, 2024

Proposed changes

Resolves #3502

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🐛bug Something isn't working 👩‍👧‍👦community feedback Feedback from community labels Dec 1, 2024
@mfranzke mfranzke self-assigned this Dec 1, 2024
@mfranzke mfranzke linked an issue Dec 1, 2024 that may be closed by this pull request
Text is displayed in light green on an invalid input element in dark mode #3502
Closed
7 tasks
@mfranzke mfranzke removed their assignment Dec 1, 2024
@github-actions github-actions bot added the 🏘components Changes inside components folder label Dec 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/3502-text-is-displayed-in-light-green-on-an-invalid-input-element-in-dark-mode

nmerget
nmerget previously approved these changes Dec 2, 2024
View reviewed changes
@mfranzke mfranzke enabled auto-merge (squash) December 2, 2024 07:13
@mfranzke mfranzke disabled auto-merge December 2, 2024 07:13
@nmerget nmerget enabled auto-merge (squash) December 2, 2024 11:15
@nmerget nmerget self-requested a review December 2, 2024 11:15
@nmerget nmerget merged commit c168430 into main Dec 2, 2024
73 checks passed
@nmerget nmerget deleted the 3502-text-is-displayed-in-light-green-on-an-invalid-input-element-in-dark-mode branch December 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🐛bug Something isn't working 👩‍👧‍👦community feedback Feedback from community 🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text is displayed in light green on an invalid input element in dark mode
2 participants
@mfranzke @nmerget