Skip to content

Refactor: update base #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dbux-3
Choose a base branch
from
+0 −106
Open

Refactor: update base #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c5fd9c
refactor: moved basic styles to base
annsch Jan 13, 2023
fa84afd
Merge branch 'dbux-3' into refactor-update-base
mfranzke Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions source/_patterns/00-base/_init.global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
@use "@db-ui/base/build/scss/variables" as *;
@use "@db-ui/base/build/scss/helpers/functions" as *;

// *! this is an opionionated (especially based on "enhancing" normalize.css) version of minireset.css v0.0.4 | MIT License | github.com/jgthms/minireset.css
html,
body {
margin: 0;
padding: 0;
}

body {
min-height: 100vh;
}

// adapted from https://github.com/jgthms/bulma/blob/0.7.5/sass/base/generic.sass
html {
background-color: #fdfdfd; // TODO: This would need to get replaced by the correct (semantic) color
Expand Down Expand Up @@ -48,16 +37,6 @@ body {
line-height: 1.5;
}

// Inline
a {
// TODO: Move to DB UI Base
color: inherit;

strong {
color: currentColor;
}
}

code {
background-color: #f5f5f5;
color: darken($db-colors-primary-enabled, 2%);
Expand All @@ -74,20 +53,10 @@ hr {
margin: 1.5rem 0;
}

img {
height: auto;
max-width: 100%;
}

small {
font-size: to-em($pxValue: 14);
}

// Block
fieldset {
border: none;
}

pre {
background-color: #f5f5f5;
color: #282d37;
Expand Down
73 changes: 0 additions & 73 deletions source/_patterns/00-base/_init.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion source/css/db-ui-core.general.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@

@import "@csstools/normalize.css/normalize";
@import "db-ui-core.variables";
@import "../_patterns/00-base/init";
1 change: 0 additions & 1 deletion source/css/enterprise/db-ui-core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ $partial: false;
@use "@db-ui/base/build/scss/color-placeholder" as *;

@use "../../_patterns/00-base/init.global" as *;
@use "../../_patterns/00-base/init" as *;

// Importing helpers
@use "@db-ui/base/build/scss/helpers/functions" as *;
Expand Down