fix: download url join (#273)

Signed-off-by: Toma Puljak <[email protected]>
daytonaio · Mar 22, 2024 · c6f44ca · c6f44ca
1 parent 3ba1dde
commit c6f44ca
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/server/api/controllers/binary/binaries.go b/pkg/server/api/controllers/binary/binaries.go
@@ -3,8 +3,8 @@ package binary
 import (
 	"fmt"
 	"net/http"
+	"net/url"
 	"os"
-	"path"
 	"path/filepath"
 	"strings"
 
@@ -61,7 +61,10 @@ func getBinaryPath(binaryName, binaryVersion string) (string, error) {
 		return binaryPath, nil
 	}
 
-	downloadUrl := path.Join(c.RegistryUrl, binaryVersion, binaryName)
+	downloadUrl, err := url.JoinPath(c.RegistryUrl, binaryVersion, binaryName)
+	if err != nil {
+		return "", err
+	}
 
 	err = daytona_os.DownloadFile(downloadUrl, binaryPath)
 	if err != nil {