Refactor AWS discovery into a separate role#15
Open
mhjacks wants to merge 2 commits into
Open
Conversation
mhjacks
changed the title
added 2 commits
December 18, 2025 15:28
# This is the 1st commit message: New patch with just site.yaml New patch with cleaner logic Remove block Remove duplicative subnet lookup code # The commit message day0hero#2 will be skipped: # Discover elements from cluster that we can # The commit message day0hero#3 will be skipped: # Add HCP check # The commit message day0hero#4 will be skipped: # Generalize VPC query # The commit message day0hero#5 will be skipped: # Retrieve VPC id # The commit message day0hero#6 will be skipped: # Query subnets # The commit message day0hero#7 will be skipped: # Add instance query but don't do it by default # The commit message day0hero#8 will be skipped: # Move values-trident to overrides directory # The commit message day0hero#9 will be skipped: # Discovering AWS stuff now # The commit message day0hero#10 will be skipped: # Fully qualify Ansible collection names; remove duplicate functionality # The commit message day0hero#11 will be skipped: # Add dirs to .gitignore
New patch with cleaner logic Remove block Remove duplicative subnet lookup code
mhjacks
force-pushed
the
refactor_aws_discovery
branch
from
6c2369f to
17194bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tags).aws_regionis nowocp_aws_regionbecause it is discovered from cluster data.