Skip to content

chore(deps-dev): bump the dev-dependencies group across 1 directory with 12 updates #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps-dev): bump the dev-dependencies group across 1 directory with 12 updates #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,19 @@
}
},
"devDependencies": {
"@changesets/cli": "3.0.0",
"@cloudflare/vitest-pool-workers": "0.20.2",
"@cloudflare/workers-types": "5.20260804.1",
"@changesets/cli": "3.0.1",
"@cloudflare/vitest-pool-workers": "0.22.0",
"@cloudflare/workers-types": "5.20260902.1",
"@eslint/js": "10.0.1",
"@fedify/fedify": "2.3.4",
"@fedify/vocab": "2.3.4",
"@types/node": "26.2.0",
"@vitest/coverage-istanbul": "4.1.10",
"eslint": "10.8.1",
"@fedify/fedify": "2.3.6",
"@fedify/vocab": "2.3.6",
"@types/node": "26.4.1",

@davidwkeith davidwkeith Sep 5, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bump (@types/node 26.2.0 → 26.4.1) breaks the build: packages/cf-shims/src/durable-object.ts(497,61): error TS2554: Expected 0 arguments, but got 1.

newUniqueId(): ShimDurableObjectId {
  return new ShimDurableObjectId(randomBytes(32).toString("hex"));
}

TypeScript is resolving .toString(...) on the Buffer returned by randomBytes to the zero-arg Uint8Array/Array.prototype.toString() overload instead of Buffer.prototype.toString(encoding) — the new @types/node patch appears to have changed how Buffer's toString override is declared relative to the Uint8Array<ArrayBufferLike> base. This fails pnpm build/pnpm typecheck for @dwk/cf-shims, which cascades into the build-test, integration, and image (Docker bundle) CI jobs — all three are currently red on this PR.

Per CONTRIBUTING.md, "the CI gate ... all five [lint, format:check, typecheck, build, test] must pass" — this shouldn't merge until that's resolved. Options: pin @types/node back to 26.2.0/a version before the regression, or adjust packages/cf-shims/src/durable-object.ts (e.g. an explicit Buffer.from(...)/type assertion) to route through the correct overload.

Generated by Claude Code

"@vitest/coverage-istanbul": "4.1.11",
"eslint": "10.9.1",
"prettier": "3.9.6",
"typescript": "6.0.3",
"typescript-eslint": "8.67.0",
"vitest": "4.1.10",
"wrangler": "4.119.0"
"typescript-eslint": "8.69.0",
"vitest": "4.1.11",
"wrangler": "4.128.0"
}
}
2 changes: 1 addition & 1 deletion packages/cf-shims/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
"@worker-tools/html-rewriter": "0.1.0-pre.19"
},
"devDependencies": {
"@types/node": "26.2.0"
"@types/node": "26.4.1"
}
}
2 changes: 1 addition & 1 deletion packages/conformance-target/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@
"@dwk/websub": "workspace:*"
},
"devDependencies": {
"@cloudflare/workers-types": "5.20260804.1"
"@cloudflare/workers-types": "5.20260902.1"
}
}
2 changes: 1 addition & 1 deletion packages/deno-host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
"access": "public"
},
"devDependencies": {
"@types/node": "26.2.0"
"@types/node": "26.4.1"
}
}
6 changes: 3 additions & 3 deletions packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"ws": "8.21.3"
},
"devDependencies": {
"@cloudflare/workers-types": "5.20260804.1",
"@cloudflare/workers-types": "5.20260902.1",
"@dwk/activitypub": "workspace:*",
"@dwk/atproto-pds": "workspace:*",
"@dwk/host-meta": "workspace:*",
Expand All @@ -88,9 +88,9 @@
"@dwk/webfinger": "workspace:*",
"@dwk/webmention": "workspace:*",
"@dwk/websub": "workspace:*",
"@libsql/client": "0.17.4",
"@libsql/client": "0.18.0",
"@types/express": "5.0.6",
"@types/node": "26.2.0",
"@types/node": "26.4.1",
"@types/ws": "8.18.1",
"aws4fetch": "1.0.20",
"esbuild": "0.28.2",
Expand Down
Loading
Loading