Skip to content

docs: drop closed queue gap from README's Deno Deploy paragraph - #420

Merged
davidwkeith merged 1 commit into
mainfrom
claude/fastly-compute-support-mc5unv
Jul 24, 2026
Merged

docs: drop closed queue gap from README's Deno Deploy paragraph#420
davidwkeith merged 1 commit into
mainfrom
claude/fastly-compute-support-mc5unv

Conversation

@davidwkeith

@davidwkeith davidwkeith commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

Packages affected

None (root README.md only — no publishable package touched).

Checklist

  • Read the relevant spec(s) under spec/packages/ and updated them if behaviour changed — not applicable, no behaviour changed; this reconciles the README with spec/packages/deno-host.md's already-current state
  • Added/updated colocated tests (src/*.test.ts) — not applicable, no code changed
  • Ran the local CI gate: pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test — full gate passes (228 test files, 2759 tests)
  • Added a changeset (pnpm changeset) if this touches a publishable package — not applicable, no publishable package touched
  • Updated catalog.json / conformance/status.json if this adds a new mountable worker or changes conformance status — not applicable, no new worker or conformance change

#418 implemented the KV-backed queue emulation (#399), leaving only
the object-storage adapter (#400) as the remaining gate for
@dwk/deno-host. Follow-up to #419 per the review thread there.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019f72oJFhroHY4eDKj5uF3M

@davidwkeith davidwkeith left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against CONTRIBUTING.md.

Content: accurate and well-scoped. The updated paragraph matches spec/packages/deno-host.md's current status verbatim — the SQL shim (#397), single-writer actor/alarm lease (#398), and KV-backed queue (#399) are implemented, and only the R2Bucket-equivalent object-storage adapter (#400) remains gated. Good follow-up to #419/#418.

Conventions: commit message and PR title use Conventional Commits (docs: ...); omitting a (scope) is reasonable here since this touches only the root README.md, not a package. PR body keeps the template's Summary / Packages affected / Checklist headings verbatim and gives one-line reasons for the inapplicable checklist items, per the contributing guide.

One minor nit: the "Ran the local CI gate" checklist item is checked [x], but its note says only npx prettier --check README.md was run, not the full pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test sequence. For a markdown-only change that's a reasonable shortcut, but CONTRIBUTING.md asks for inapplicable/partial items to be left unchecked with the one-line reason rather than checked — consider flipping that box to [ ] (or just running the full gate, which is cheap here). Not blocking; CI's own build-test/release-gate jobs will catch any real regression either way.

No other issues found.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Fixed the nit — ran the full local CI gate (pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test; 228 test files, 2759 tests, all passing) and updated the checklist item to reflect that instead of the partial prettier --check note. The github-advanced-security check failure is the same unrelated platform issue seen on #418/#419.


Generated by Claude Code

@davidwkeith
davidwkeith merged commit 0820a59 into main Jul 24, 2026
8 of 9 checks passed
@davidwkeith
davidwkeith deleted the claude/fastly-compute-support-mc5unv branch July 24, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants