docs(micropub): define location venue query - #366
Conversation
davidwkeith
left a comment
There was a problem hiding this comment.
Automated code review.
CONTRIBUTING.md conformance: PASS. Title/scope and PR template headings are correct. The changeset "not applicable" classification was verified — the diff only touches packages/micropub/README.md, packages/micropub/src/index.test.ts, and spec/packages/micropub.md; the new test only exercises the pre-existing (already-disabled) q=geo fallthrough to the 400 invalid_request branch, adding no production logic. So this really is docs+regression-test only, and "not applicable" for the changeset is accurate.
Content issues found (all minor, no blockers):
-
Should-fix — "Exactly one position form is accepted" in the "Enablement, request, and validation" section reads oddly; likely meant "positional form." Worth a quick wording pass.
-
Nit — it's implicit rather than stated that a standalone
u=combined withuri=(which already carries its own;u=) must be rejected. The "forms cannot be combined" sentence coverslat/lonvsuri, notualongsideuri. A one-clause callout would remove the ambiguity for whoever implements this. -
Nit — radius
uis defined as "non-negative," sou=0is technically permitted (matches only exact-coincident points). Worth an explicit note on whether zero-radius is meaningful or should be rejected.
Spec structure/conventions (heading nesting, MUST/must usage, response-shape conventions) match the rest of spec/packages/micropub.md, and the README's new anchor link resolves correctly against GitHub's heading-slug algorithm. Nice clean spec addition overall.
Generated by Claude Code
|
Addressed the review feedback in ec17f4a:
Formatting and diff checks pass. There were no unresolved inline review threads to resolve. |
ec17f4a to
ada9b8e
Compare
952fa75 to
08b4d85
Compare
Summary
Defines the proposed, default-off
q=geoLocation/Venue contract for #359. It specifies interoperable Geo URI and coordinate inputs, radius and pagination semantics, thegeo/venuesresponse, deterministic ordering, venue lifecycle, and the injected strongly-consistentVenueStoreseam. Adds a regression test confirming disabled deployments neither advertise nor serveq=geo.Packages affected
Checklist
spec/packages/and updated them if behaviour changedsrc/*.test.ts)pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test— targeted Micropub tests and typecheck passed; full gate was not run.pnpm changeset) if this touches a publishable package — not applicable; this documents a future, unimplemented extension.catalog.json/conformance/status.jsonif this adds a new mountable worker or changes conformance status — not applicable; no worker or conformance status changed.