Skip to content

docs(micropub): define location venue query - #366

Merged
davidwkeith merged 2 commits into
mainfrom
codex/issue-359-location-venue
Jul 22, 2026
Merged

docs(micropub): define location venue query#366
davidwkeith merged 2 commits into
mainfrom
codex/issue-359-location-venue

Conversation

@davidwkeith

Copy link
Copy Markdown
Owner

Summary

Defines the proposed, default-off q=geo Location/Venue contract for #359. It specifies interoperable Geo URI and coordinate inputs, radius and pagination semantics, the geo/venues response, deterministic ordering, venue lifecycle, and the injected strongly-consistent VenueStore seam. Adds a regression test confirming disabled deployments neither advertise nor serve q=geo.

Packages affected

  • @dwk/micropub

Checklist

  • Read the relevant spec(s) under spec/packages/ and updated them if behaviour changed
  • Added/updated colocated tests (src/*.test.ts)
  • Ran the local CI gate: pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test — targeted Micropub tests and typecheck passed; full gate was not run.
  • Added a changeset (pnpm changeset) if this touches a publishable package — not applicable; this documents a future, unimplemented extension.
  • Updated catalog.json / conformance/status.json if this adds a new mountable worker or changes conformance status — not applicable; no worker or conformance status changed.

@davidwkeith davidwkeith left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review.

CONTRIBUTING.md conformance: PASS. Title/scope and PR template headings are correct. The changeset "not applicable" classification was verified — the diff only touches packages/micropub/README.md, packages/micropub/src/index.test.ts, and spec/packages/micropub.md; the new test only exercises the pre-existing (already-disabled) q=geo fallthrough to the 400 invalid_request branch, adding no production logic. So this really is docs+regression-test only, and "not applicable" for the changeset is accurate.

Content issues found (all minor, no blockers):

  1. Should-fix — "Exactly one position form is accepted" in the "Enablement, request, and validation" section reads oddly; likely meant "positional form." Worth a quick wording pass.

  2. Nit — it's implicit rather than stated that a standalone u= combined with uri= (which already carries its own ;u=) must be rejected. The "forms cannot be combined" sentence covers lat/lon vs uri, not u alongside uri. A one-clause callout would remove the ambiguity for whoever implements this.

  3. Nit — radius u is defined as "non-negative," so u=0 is technically permitted (matches only exact-coincident points). Worth an explicit note on whether zero-radius is meaningful or should be rejected.

Spec structure/conventions (heading nesting, MUST/must usage, response-shape conventions) match the rest of spec/packages/micropub.md, and the README's new anchor link resolves correctly against GitHub's heading-slug algorithm. Nice clean spec addition overall.


Generated by Claude Code

@davidwkeith
davidwkeith marked this pull request as ready for review July 22, 2026 14:45
@davidwkeith

Copy link
Copy Markdown
Owner Author

Addressed the review feedback in ec17f4a:

  • corrected "position form" to "positional form";
  • explicitly reject standalone u alongside uri, including when the URI has no ;u= component; and
  • explicitly define u=0 as an exact-coordinate-only search rather than normalizing it to the default radius.

Formatting and diff checks pass. There were no unresolved inline review threads to resolve.

@davidwkeith
davidwkeith force-pushed the codex/issue-359-location-venue branch from ec17f4a to ada9b8e Compare July 22, 2026 15:49
@davidwkeith
davidwkeith enabled auto-merge (squash) July 22, 2026 19:32
@davidwkeith
davidwkeith force-pushed the codex/issue-359-location-venue branch from 952fa75 to 08b4d85 Compare July 22, 2026 21:03
@davidwkeith
davidwkeith merged commit 4a94965 into main Jul 22, 2026
8 of 9 checks passed
@davidwkeith
davidwkeith deleted the codex/issue-359-location-venue branch July 22, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant