Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade focus-group dep to 0.3.1 #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micahroberson
Copy link

Summary
In working with a project using both react-aria-menubutton and react-aria-tabpanel (awesome libs by the way - thank you!!), I noticed each depends on a different version of focus-group. For bundling purposes, this is problematic (if only 0.3.1 is included, the options API change introduced in 0.3.0, causes left/right navigation to be broken), so this PR aims to update focus-group to latest (0.3.1) and fix compatibility.

Test Plan
Confirmed left/right navigation is broken with 0.3.1
Confirmed left/right navigation is fixed with changes to lib/createManager.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant