Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In working with a project using both
react-aria-menubutton
andreact-aria-tabpanel
(awesome libs by the way - thank you!!), I noticed each depends on a different version offocus-group
. For bundling purposes, this is problematic (if only0.3.1
is included, theoptions
API change introduced in0.3.0
, causes left/right navigation to be broken), so this PR aims to updatefocus-group
to latest (0.3.1
) and fix compatibility.Test Plan
Confirmed left/right navigation is broken with
0.3.1
Confirmed left/right navigation is fixed with changes to
lib/createManager.js