Skip to content

Add @escaping to handleNextItem completion closure #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add @escaping to handleNextItem completion closure #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion YapTaskQueue/Classes/YapTaskQueueBroker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public enum DatabaseStrings:String {
/** This method is called when an item is available to be exectued. Call completion once finished with the action item.

*/
func handleNextItem(_ action:YapTaskQueueAction, completion:(_ success:Bool, _ retryTimeout:TimeInterval)->Void)
func handleNextItem(_ action:YapTaskQueueAction, completion:@escaping(_ success:Bool, _ retryTimeout:TimeInterval)->Void)
}

/// YapTaskQueueBroker is a subclass of YapDatabaseFilteredView. It listens for changes and manages the timing of running an action.
Expand Down
2 changes: 1 addition & 1 deletion YapTaskQueue/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class MessageSendAction:NSObject, NSCoding, YapTaskQueueAction {

class MessageHandler:YapTaskQueueHandler {

@objc func handleNextItem(_ action: YapTaskQueueAction, completion: (_ success: Bool, _ retryTimeout: TimeInterval) -> Void) {
@objc func handleNextItem(_ action: YapTaskQueueAction, completion:@escaping (_ success: Bool, _ retryTimeout: TimeInterval) -> Void) {
guard action is MessageSendAction else {
completion(false, -1)
return
Expand Down
2 changes: 1 addition & 1 deletion YapTaskQueueTests/YapTaskQueueTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ open class TestHandler:YapTaskQueueHandler {
self.handleBlock = handleBlock
}

@objc open func handleNextItem(_ action: YapTaskQueueAction, completion: (_ success: Bool, _ retryTimeout: TimeInterval) -> Void) {
@objc open func handleNextItem(_ action: YapTaskQueueAction, completion:@escaping (_ success: Bool, _ retryTimeout: TimeInterval) -> Void) {

guard let testObject = action as? TestActionObject else {
completion(false, DBL_MAX)
Expand Down