feat: replace global year selector with per-page date range filters (Story 17.12)#296
Merged
daveharmswebdev merged 4 commits intomainfrom Mar 7, 2026
Merged
Conversation
…Story 17.12) Replace the global YearSelectorService/YearSelectorComponent (sidebar widget → singleton service → effects in 4 components) with local DateRangeFilterComponent instances on Dashboard, Properties list, and Property detail pages. Add dateFrom/dateTo query params to backend endpoints with year-based fallback for backward compatibility. Decouple Income and Report dialogs from the removed global year state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… added All Time option Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…m shared store, cleanup - Replace 3 separate date signals with single dateRange signal + computed projections to prevent double effect fires on preset change (Dashboard, Properties, PropertyDetail) - Move propertyId assignment to constructor so effect has it on first fire (PropertyDetail) - BatchReportDialog now fetches properties via PropertyService with year-scoped dates instead of reading date-filtered data from shared PropertyStore singleton - Remove dead .year-selector-panel CSS from global styles (AC-7 cleanup) - Remove empty ngOnInit / implements OnInit from Dashboard and Properties components - Remove unused imports (effect, PropertyStore) from BatchReportDialog Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YearSelectorService+YearSelectorComponentwith per-pageDateRangeFilterComponentinstances on Dashboard, Properties list, and Property detaildateFrom/dateToquery params to 3 backend endpoints (GetAllProperties,GetPropertyById,GetDashboardTotals) with backward-compatibleyearfallbacklast-yearpreset toDateRangeFilterComponentandDateRangePresettypeYearSelectorService,YearSelectorComponent, and all related files (−913 lines)Acceptance Criteria
Test plan
GitHub Issue: #279
🤖 Generated with Claude Code