Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring monitor layout for rofi #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactoring monitor layout for rofi #9

wants to merge 7 commits into from

Conversation

rememberYou
Copy link

@rememberYou rememberYou commented May 12, 2018

First of all, I want to thank you for your work. I allowed myself to refactor the code for the monitor_layout.sh script.

This refactorization includes:

  • Adding global documentation
  • Deleting unnecessary variables.
  • Display correction for dual screen: it is more logical that (A -> B) means that A is to the left of B.
  • Better display by adding two points after the number (0 Cancel -> 0: Cancel).
  • Redundant code reduction.
  • Arrows with Font Awesome 5 (can be removed if you want to avoid dependencies).

NOTE: before accepting this pull request, it would first be wise to first accept this one

My apologies for the reversal of order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant