Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKC-693 Support for Spark 3.3 #1351

Merged
merged 3 commits into from
Jan 2, 2023

Conversation

tobiasstadler
Copy link
Contributor

Description

How did the Spark Cassandra Connector Work or Not Work Before this Patch

Spark Cassandra Connector did not work with Spark 3.3 before this patch

General Design of the patch

Updated Spark to 3.3, fixed compilation and tests

How Has This Been Tested?

unit and integration tests

Checklist:

  • I have a ticket in the OSS JIRA
  • I have performed a self-review of my own code
  • Locally all tests pass (make sure tests fail without your patch)

@ErickRamirezAU
Copy link
Contributor

@tobiasstadler thanks for submitting the PR!

  1. Please add a note to SPARKC-693 so everyone else on the ticket is aware that you've submitted a PR.
  2. If you haven't already, please sign the Contributor License Agreement.

Thanks again. Cheers! 🍻

project/Versions.scala Outdated Show resolved Hide resolved
Co-authored-by: Jack Richard Buggins <[email protected]>
@JackBuggins
Copy link
Contributor

JackBuggins commented Dec 22, 2022

I think the final small task I can see is to pop a note for docs under version-compatibility in the README.md, as well as changes.txt, 👍 on everything else here.

@tobiasstadler
Copy link
Contributor Author

@JackBuggins I update the version compatibility

@tobiasstadler
Copy link
Contributor Author

@ErickRamirezAU / @JackBuggins Is there anything missing from my side?

@JackBuggins
Copy link
Contributor

Not to my knowledge @tobiasstadler, thank you. It is now for code owner review from @ErickRamirezAU et al.

@jtgrabowski jtgrabowski merged commit 9eb9e81 into datastax:master Jan 2, 2023
@jtgrabowski
Copy link
Collaborator

This is awesome, thank you for the contribution! Would you be interested into looking into Scala 2.13 support?

@tobiasstadler
Copy link
Contributor Author

Thank You! Do you have any plans for a 3.3 release?

@tobiasstadler tobiasstadler deleted the SPARKC-693 branch January 2, 2023 10:19
@jtgrabowski
Copy link
Collaborator

We can do a release without 2.13 and add it later. I'll do a release this week. Thanks again!

@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jan 2, 2023

@jtgrabowski afaik #1349 has support for Scala 2.13

@jtgrabowski
Copy link
Collaborator

I asked the author for a followup, if there is no movement for a couple of days I'll release without 2.13 support.

@tobiasstadler
Copy link
Contributor Author

@jtgrabowski Could you please do a release without Scala 2.13 support?

@jtgrabowski
Copy link
Collaborator

Yeah, I'm planning to release it today.

@tobiasstadler
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants