Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump torch version to 2.4.0 #633

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/ci-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ jobs:
matrix:
python-version:
- "3.12"
- "3.11"
- "3.10"
- "3.9"
# - "3.11"
# - "3.10"
# - "3.9"
steps:
- name: Check out the repo
uses: actions/checkout@v4
Expand All @@ -127,14 +127,14 @@ jobs:
with:
python-version: "${{ matrix.python-version }}"

- name: "Unit tests (root)"
# yamllint disable-line rule:line-length
if: ${{ needs.preconditions.outputs.libs_langchain == 'true' || needs.preconditions.outputs.libs_colbert == 'true' || needs.preconditions.outputs.libs_llamaindex == 'true' }}
run: tox -e unit-tests && rm -rf .tox

- name: "Unit tests (ragulate)"
if: ${{ needs.preconditions.outputs.libs_ragulate == 'true' && matrix.python-version != '3.9' }}
run: tox -e unit-tests -c libs/ragulate && rm -rf libs/ragulate/.tox
# - name: "Unit tests (root)"
# # yamllint disable-line rule:line-length
# if: ${{ needs.preconditions.outputs.libs_langchain == 'true' || needs.preconditions.outputs.libs_colbert == 'true' || needs.preconditions.outputs.libs_llamaindex == 'true' }}
# run: tox -e unit-tests && rm -rf .tox
#
# - name: "Unit tests (ragulate)"
# if: ${{ needs.preconditions.outputs.libs_ragulate == 'true' && matrix.python-version != '3.9' }}
# run: tox -e unit-tests -c libs/ragulate && rm -rf libs/ragulate/.tox

- name: "Unit tests (colbert)"
if: ${{ needs.preconditions.outputs.libs_colbert == 'true' }}
Expand Down
6 changes: 1 addition & 5 deletions libs/colbert/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,10 @@ packages = [{ include = "ragstack_colbert" }]
python = ">=3.9,<4.0"
colbert-ai = "0.2.19"
pyarrow = "14.0.1"
torch = "2.2.1"
torch = "2.4.0"
cassio = "~0.1.7"
pydantic = "^2.7.1"

# Workaround for https://github.com/pytorch/pytorch/pull/127921
# Remove when we upgrade to pytorch 2.4
setuptools = { version = ">=70", python = ">=3.12" }

[tool.poetry.group.dev.dependencies]
mypy = "^1.11.0"

Expand Down
7 changes: 6 additions & 1 deletion libs/colbert/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@ envlist = type, unit-tests, integration-tests
[testenv]
description = install dependencies
skip_install = true
allowlist_externals = poetry
allowlist_externals =
poetry
cat
commands_pre =
poetry env use system
poetry lock
poetry update -vvv
poetry install
cat .tox/unit-tests/lib/python3.12/site-packages/torch-2.4.0.dist-info/METADATA

[testenv:unit-tests]
description = run unit tests
Expand Down
Empty file added libs/testa/testa/__init__.py
Empty file.
Loading