adding MimeNode type #503
Open
adding MimeNode type #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into knowledge_store/mime
bjchambers
reviewed
Jun 20, 2024
| method_map = method_map if method_map else {} | ||
| other_methods = other_methods if other_methods else [] | ||
|
|
||
| base_methods = ['embed_texts', 'aembed_texts', 'embed_query', 'aembed_query'] |
There was a problem hiding this comment.
I don't think we should try to add all of these as methods, it's definitely pretty messy.
I think we should just have embed_mime(self, mime_type: str, content: Union[str, Bytes]) or something like that. Then there is only a single abstract method to use for any mime type and the names can be different, etc.
There was a problem hiding this comment.
100% but right now, LangChain doesn't have "embed_mime" :)
|
|
||
| # Step 1: Add the nodes, collecting the tags and new sources / targets. | ||
| tag_to_new_sources = {} |
There was a problem hiding this comment.
This has changed significantly from the previous implementation. I think it will need to be reworked if we work on adding this right now.
# Conflicts: # libs/knowledge-store/ragstack_knowledge_store/graph_store.py # libs/langchain/ragstack_langchain/graph_store/base.py # libs/langchain/ragstack_langchain/graph_store/cassandra.py
|
Shall we close this one ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.