Move float bulk-write into IndexWriter to enforce endianness #577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most places, the byte order is
BIG_ENDIANdue to:DataInput/DataOutputmethod contractsByteBuffer.order(ByteOrder.BIG_ENDIAN)The exception is the bulk-float write call in
ArrayVectorProvider, which will default to the native byte-order.While changing the byte order there to
BIG_ENDIANwould fix this, it still does not allow consumers of this library to override this behavior (where they may wish to readLITTLE_ENDIANin their implementation ofRandomAccessReaderdue to the static initialization of theVectorTypeSupport.So this PR adds a bulk
writeFloatstoIndexWriterand uses that interface overDataOutputwhere necessary.I also took the liberty to add a missing
.order(BIG_ENDIAN)call inSimpleMappedReader.Unrelated changes include:
jdtlsLSP files to.gitignoreProductQuantizationrelated to type inference ofRunnablerather thanCallableCloses #576.