Skip to content

Conversation

@michaeljmarshall
Copy link
Member

See comment: https://github.com/datastax/jvector/pull/536/files#r2453090826

In #536, there was an addition that prevented concurrent addition of vectors to the RandomAccessVectorValues object. This behavior has been allowed in downstream projects, so I propose we return to it. Further, I replaced an identity map array with a simple OrdinalMapper identity function. It might be confusing to use the OrdinalMapper, but in reading it's javadoc, I think it applies here.

The added test fails without this change.

@github-actions
Copy link
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

@marianotepper
Copy link
Collaborator

@sam-herman please take a look at this PR. As it is an improvement over #536

Copy link
Collaborator

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marianotepper
Copy link
Collaborator

IMO, #555 is the preferred fix for this, so I think we should not merge this PR and go with the other one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants