Fix BuildScoreProvider::randomAccessScoreProvider bug #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment: https://github.com/datastax/jvector/pull/536/files#r2453090826
In #536, there was an addition that prevented concurrent addition of vectors to the
RandomAccessVectorValuesobject. This behavior has been allowed in downstream projects, so I propose we return to it. Further, I replaced an identity map array with a simpleOrdinalMapperidentity function. It might be confusing to use theOrdinalMapper, but in reading it's javadoc, I think it applies here.The added test fails without this change.