Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFX-1605] DR AF Provider - Remove declared python 3.13 support #162

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

c-h-russell-walker
Copy link
Contributor

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Summary

Trying to pip install our package in a 3.13 virtual env fails:
Collecting google-re2>=1.0 (from apache-airflow>=2.6.0->airflow-provider-datarobot)

Screenshot 2025-02-17 at 4 28 21 PM

Rationale

Looks like there's a known issue here:
google/re2#516

And also apache-airflow only declares support up to 3.12:
https://pypi.org/project/apache-airflow/
Screenshot 2025-02-18 at 8 33 10 AM

@devexp-slackbot devexp-slackbot bot changed the title [YOLO] DR AF Provider - Remove declared python 3.13 support [CFX-1605] DR AF Provider - Remove declared python 3.13 support Feb 18, 2025
@devexp-slackbot
Copy link

The Needs Review labels were added based on the following file changes.

Team @datarobot/machine-learning-development (#machine-learning-dev) was assigned because of changes in files:

setup.py
setup_early_access.py

If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file.

Copy link
Collaborator

@mjnitz02 mjnitz02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Yea, we don't have grid unit testing for 3.13 yet, so this was added by mistake.

@c-h-russell-walker
Copy link
Contributor Author

Thanks for catching this. Yea, we don't have grid unit testing for 3.13 yet, so this was added by mistake.

Credit's due to @vivekrohillaDRB for finding the issue 😎

@c-h-russell-walker c-h-russell-walker merged commit b901776 into main Feb 18, 2025
4 checks passed
@svc-engprod-git1 svc-engprod-git1 deleted the chrisrw/YOLO_remove_declared_py313_support branch February 18, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants