Update main from develop #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
datalogics-aarroyo
commented
Mar 18, 2024
datalogics-aarroyo
commented
- Add new QRCode sample
…ions-workflow Add initial GitHub Actions workflow file to repo
Add QRCode sample.
- The Office conversion API is not implemented on Mac platforms, so let's add some logic to prevent building and running the ConvertToOffice sample on Mac.
- The XPS conversion API is not implemented on Mac platforms, so let's add some logic to prevent building and running the CreateDocFromXPS sample on Mac.
- On Windows, running the samples via DLL for the ConvertToOffice, CreateDocFromXPS, PDFAConverter, and PDFXConverter sample caused the samples to throw exceptions. This is likely due to the APDFL plugins not being in the Windows DLL search path. To get around this for CI, let's run the sample exe for samples that are run on Windows. - Rename dll_name variable for clarity.
- Here's an SO that specifies how to install MS Core Fonts in a script: https://askubuntu.com/a/25614. Let's try out this method to see if it works.
- The Redactions sample throws an exception on the Ubuntu GitHub Actions runner. However, when it runs on a CentOS machine, the sample does not throw an exception.
- Also, add some debugging code to list files to the workflow file.
- Also, remove the debugging statements.
- The upload-artifact action supposedly supports relative paths, but it threw an error when relative paths were used. There also seems to be a few open bugs reported on GitHub, here's one: actions/upload-artifact#176. - Since some of the samples dump their output in the parent directory, let's try a workaround to see if we can archive them in the workflow run.
- The workaround that was attempted to access the parent directory where some samples were putting their output didn't work because the upload-artifact action tries to find the common ancestor and searches there. Therefore, it didn't end up finding the output files. Let's remove the attempted workaround. - Let's just modify the samples to place their output in the current working directory, which is the same as the rest of the samples.
- Let's make the workflow a bit more readable. - Let's make sure we run the new AddQRCode sample in CI.
datalogics-aarroyo
added
the
merge at public release
datalogics-robl
approved these changes
Mar 18, 2024
datalogics-robl
approved these changes
Mar 18, 2024
…NET-samples APDFL-5452: Add CI for samples
Fix sample warnings seen during workflow build.
Because Spot Colorants may only be part of Annotation appearances, to do a proper DeviceN rendering of all colorants this needs to be set. Otherwise we collect all the spot colorants including those of Annotation appearances and setup our DeviceN rendering with it....but at the same time we tell PDFL with our render flags "don't consider them", leading to scrambled output.
Fix render flag setting.
datalogics-robl
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.