APDFL-5452: Add CI for samples #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
13 times, most recently
from
64f9d5d to
2e20376
Compare
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
17 times, most recently
from
322df59 to
14def04
Compare
- The Redactions sample throws an exception on the Ubuntu GitHub Actions runner. However, when it runs on a CentOS machine, the sample does not throw an exception.
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
2 times, most recently
from
e11c732 to
a1d1823
Compare
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
4 times, most recently
from
acf45d4 to
0a2d5ed
Compare
- Also, add some debugging code to list files to the workflow file.
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
from
0a2d5ed to
3a1d23c
Compare
- Also, remove the debugging statements.
- The upload-artifact action supposedly supports relative paths, but it threw an error when relative paths were used. There also seems to be a few open bugs reported on GitHub, here's one: actions/upload-artifact#176. - Since some of the samples dump their output in the parent directory, let's try a workaround to see if we can archive them in the workflow run.
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
from
4e19b83 to
c4c3950
Compare
- The workaround that was attempted to access the parent directory where some samples were putting their output didn't work because the upload-artifact action tries to find the common ancestor and searches there. Therefore, it didn't end up finding the output files. Let's remove the attempted workaround. - Let's just modify the samples to place their output in the current working directory, which is the same as the rest of the samples.
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
from
0fa5362 to
5885937
Compare
- Let's make the workflow a bit more readable. - Let's make sure we run the new AddQRCode sample in CI.
datalogics-saharay
force-pushed
the
APDFL-5452-add-CI-for-NET-samples
branch
from
5885937 to
346423f
Compare
datalogics-aarroyo
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add CI for the samples, so that we can ensure that they can be built and run.
Fulfills JIRA issue: APDFL-5452