Improve dataset file handling tests in test_datasets.py::test_file_handling#280
Open
christian-monch wants to merge 6 commits intodatalad:mainfrom
Open
Improve dataset file handling tests in test_datasets.py::test_file_handling#280christian-monch wants to merge 6 commits intodatalad:mainfrom
test_datasets.py::test_file_handling#280christian-monch wants to merge 6 commits intodatalad:mainfrom
Conversation
Member
|
I ran the test that fails on windows locally because Appveyor is booked out, and saw this: |
bpoldrack
reviewed
Mar 17, 2023
adswa
reviewed
Mar 17, 2023
This commit modifies test_datasets.test_file_handling to be able to test with remote paths that contain directories. There is still a possible improvment: support files with non ".txt" suffix. Those are currently not supported because replace file fails due to "changing file types".
co-authored by @adswa, @bpoldrack Use suggestions by Ben and Adina to improve the code Rebased on main
1e954de to
fae7605
Compare
…s-with-directories
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 93.78% 93.81% +0.03%
==========================================
Files 17 17
Lines 965 954 -11
==========================================
- Hits 905 895 -10
+ Misses 60 59 -1
☔ View full report in Codecov by Sentry. |
adswa
approved these changes
Oct 5, 2023
Member
adswa
left a comment
There was a problem hiding this comment.
this PR is a bit dated and seemingly got lost after the development sprint, but I rebased it and all the tests pass, and I can't see anything wrong with it.
…s-with-directories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
test_datasets.py::test_file_handlingto be able to test with remote paths that contain directories.There are still possible improvements: support files with non ".txt" suffix. Those are currently not supported because replace file fails due to "changing file types".