feat(chart): option to not create clusterRoles; #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts @AdheipSingh ? |
|
Hey @AdheipSingh we'd really love to see a new release with this and #162 (already merged) included. Let me know if you have any concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #170 and #162
When destroying and re-creating the operator (for example when moving to another namespace) we want to keep CRDs and ClusterRoles around. This PR adds an option
createClusterRolesto the helm chart which can be used to re-create the operator without re-creating the ClusterRoles, which would currently fail.The default value is true and thus default behavior of the chart will not change.
This PR has: