Skip to content

chore(plugins): Convert All Plugins Using entity-registry to Spring Configuration #14181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alexsku
Copy link
Collaborator

@alexsku alexsku commented Jul 22, 2025

This PR completes the migration of all remaining plugins from YAML configuration in entity-registry.yml to Spring beans, unifying the plugin management system under Spring's dependency injection framework. 8 plugins have been successfully migrated across aspectPayloadValidators, mutationHooks, and mcpSideEffects categories, including CreateIfNotExistsValidator, ConditionalWriteValidator, FieldPathMutator, OwnershipOwnerTypes, StructuredPropertiesSoftDelete, PropertyDefinitionValidator, StructuredPropertiesValidator, and PropertyDefinitionDeleteSideEffect. All plugins now follow a consistent Spring bean pattern in SpringStandardPluginConfiguration.java with proper AspectPluginConfig setup and corresponding test coverage, providing better type safety, compile-time validation, and unified configuration management while maintaining full backward compatibility and functionality.

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.opensearch.SearchGraphServiceOpenSearchTest.xml at 668:1052

Caused by:
RuntimeError: Error converting computed name to ValidatedString

Caused by:
    string is too long</code></pre>

For more help, visit our troubleshooting guide.

:loudspeaker: Thoughts on this report? Let us know!

Copy link

alwaysmeticulous bot commented Jul 22, 2025

✅ Meticulous spotted 0 visual differences across 1435 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit a5559cb. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 22, 2025

Bundle Report

Changes will decrease total bundle size by 37.52kB (-0.17%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.24MB -37.52kB (-0.17%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -37.12kB 18.61MB -0.2%
assets/index-*.css -396 bytes 608.85kB -0.06%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant