Skip to content

feat(customHomePage): add related entities filters to hierarchy module #14179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025

Conversation

v-tarasevich-blitz-brain
Copy link
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Jul 22, 2025

image

Reducing of vertical size:
image

Redesign of inputs (redesigned only supportable filters):
image
image

Supportable filters:
image

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-586-custom-home-page--add-filters branch from 3cb653e to 5cbdc56 Compare July 22, 2025 16:16
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jul 22, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--ch-586-custom-home-page--add-filters branch from 5cbdc56 to 71fbdf3 Compare July 23, 2025 09:35
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain changed the title [WIP] Vt ch 586 custom home page add filters feat(customHomePage): add related entities filters to hierarchy module Jul 23, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain marked this pull request as ready for review July 23, 2025 09:37
Copy link

codecov bot commented Jul 23, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.elasticsearch.SearchGraphServiceElasticSearchTest.xml at 684:1058

Caused by:
RuntimeError: Error converting computed name to ValidatedString

Caused by:
    string is too long</code></pre>

For more help, visit our troubleshooting guide.


:x: 7 Tests Failed:

Tests completed Failed Passed Skipped
6393 7 6386 71
View the top 3 failed test(s) by shortest run time
tests.integration.kafka-connect.test_kafka_connect::test_kafka_connect_debezium_sqlserver
Stack Traces | 0.001s run time
docker_compose_runner = <function docker_compose_runner.<locals>.run at 0x7f5aa8697c20>
pytestconfig = <_pytest.config.Config object at 0x7f5b907dabd0>
test_resources_dir = PosixPath('.../tests/integration/kafka-connect')

    @pytest.fixture(scope="module")
    def kafka_connect_runner(docker_compose_runner, pytestconfig, test_resources_dir):
        test_resources_dir_kafka = pytestconfig.rootpath / "tests/integration/kafka"
    
        # Share Compose configurations between files and projects
        # https://docs.docker.com/compose/extends/
        docker_compose_file = [
            str(test_resources_dir_kafka / "docker-compose.yml"),
            str(test_resources_dir / "docker-compose.override.yml"),
        ]
    
        with docker_compose_runner(docker_compose_file, "kafka-connect") as docker_services:
            # We rely on Docker health checks to confirm all services are up & healthy
    
            # However healthcheck for test_connect service is not very trustable, so
            # a double and more robust check here is needed
>           docker_services.wait_until_responsive(
                timeout=300,
                pause=10,
                check=lambda: check_connectors_ready(
                    KAFKA_CONNECT_SERVER, only_plugins=True
                ),
            )

.../integration/kafka-connect/test_kafka_connect.py:136: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = Services(_docker_compose=DockerComposeExecutor(_compose_command='docker compose --parallel -1', _compose_files=['/home...tegration/kafka-connect/docker-compose.override.yml'], _compose_project_name='pytest5561-kafka-connect'), _services={})
check = <function kafka_connect_runner.<locals>.<lambda> at 0x7f5aa8696570>
timeout = 300, pause = 10, clock = <built-in function perf_counter>

    def wait_until_responsive(
        self,
        check: Any,
        timeout: float,
        pause: float,
        clock: Any = timeit.default_timer,
    ) -> None:
        """Wait until a service is responsive."""
    
        ref = clock()
        now = ref
        while (now - ref) < timeout:
            if check():
                return
            time.sleep(pause)
            now = clock()
    
>       raise Exception("Timeout reached while waiting on service!")
E       Exception: Timeout reached while waiting on service!

venv/lib/python3.11.../site-packages/pytest_docker/plugin.py:119: Exception
tests.integration.kafka-connect.test_kafka_connect::test_kafka_connect_ingest_stateful
Stack Traces | 0.001s run time
docker_compose_runner = <function docker_compose_runner.<locals>.run at 0x7f5aa8697c20>
pytestconfig = <_pytest.config.Config object at 0x7f5b907dabd0>
test_resources_dir = PosixPath('.../tests/integration/kafka-connect')

    @pytest.fixture(scope="module")
    def kafka_connect_runner(docker_compose_runner, pytestconfig, test_resources_dir):
        test_resources_dir_kafka = pytestconfig.rootpath / "tests/integration/kafka"
    
        # Share Compose configurations between files and projects
        # https://docs.docker.com/compose/extends/
        docker_compose_file = [
            str(test_resources_dir_kafka / "docker-compose.yml"),
            str(test_resources_dir / "docker-compose.override.yml"),
        ]
    
        with docker_compose_runner(docker_compose_file, "kafka-connect") as docker_services:
            # We rely on Docker health checks to confirm all services are up & healthy
    
            # However healthcheck for test_connect service is not very trustable, so
            # a double and more robust check here is needed
>           docker_services.wait_until_responsive(
                timeout=300,
                pause=10,
                check=lambda: check_connectors_ready(
                    KAFKA_CONNECT_SERVER, only_plugins=True
                ),
            )

.../integration/kafka-connect/test_kafka_connect.py:136: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = Services(_docker_compose=DockerComposeExecutor(_compose_command='docker compose --parallel -1', _compose_files=['/home...tegration/kafka-connect/docker-compose.override.yml'], _compose_project_name='pytest5561-kafka-connect'), _services={})
check = <function kafka_connect_runner.<locals>.<lambda> at 0x7f5aa8696570>
timeout = 300, pause = 10, clock = <built-in function perf_counter>

    def wait_until_responsive(
        self,
        check: Any,
        timeout: float,
        pause: float,
        clock: Any = timeit.default_timer,
    ) -> None:
        """Wait until a service is responsive."""
    
        ref = clock()
        now = ref
        while (now - ref) < timeout:
            if check():
                return
            time.sleep(pause)
            now = clock()
    
>       raise Exception("Timeout reached while waiting on service!")
E       Exception: Timeout reached while waiting on service!

venv/lib/python3.11.../site-packages/pytest_docker/plugin.py:119: Exception
tests.integration.kafka-connect.test_kafka_connect::test_kafka_connect_mongosourceconnect_ingest
Stack Traces | 0.001s run time
docker_compose_runner = <function docker_compose_runner.<locals>.run at 0x7f5aa8697c20>
pytestconfig = <_pytest.config.Config object at 0x7f5b907dabd0>
test_resources_dir = PosixPath('.../tests/integration/kafka-connect')

    @pytest.fixture(scope="module")
    def kafka_connect_runner(docker_compose_runner, pytestconfig, test_resources_dir):
        test_resources_dir_kafka = pytestconfig.rootpath / "tests/integration/kafka"
    
        # Share Compose configurations between files and projects
        # https://docs.docker.com/compose/extends/
        docker_compose_file = [
            str(test_resources_dir_kafka / "docker-compose.yml"),
            str(test_resources_dir / "docker-compose.override.yml"),
        ]
    
        with docker_compose_runner(docker_compose_file, "kafka-connect") as docker_services:
            # We rely on Docker health checks to confirm all services are up & healthy
    
            # However healthcheck for test_connect service is not very trustable, so
            # a double and more robust check here is needed
>           docker_services.wait_until_responsive(
                timeout=300,
                pause=10,
                check=lambda: check_connectors_ready(
                    KAFKA_CONNECT_SERVER, only_plugins=True
                ),
            )

.../integration/kafka-connect/test_kafka_connect.py:136: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = Services(_docker_compose=DockerComposeExecutor(_compose_command='docker compose --parallel -1', _compose_files=['/home...tegration/kafka-connect/docker-compose.override.yml'], _compose_project_name='pytest5561-kafka-connect'), _services={})
check = <function kafka_connect_runner.<locals>.<lambda> at 0x7f5aa8696570>
timeout = 300, pause = 10, clock = <built-in function perf_counter>

    def wait_until_responsive(
        self,
        check: Any,
        timeout: float,
        pause: float,
        clock: Any = timeit.default_timer,
    ) -> None:
        """Wait until a service is responsive."""
    
        ref = clock()
        now = ref
        while (now - ref) < timeout:
            if check():
                return
            time.sleep(pause)
            now = clock()
    
>       raise Exception("Timeout reached while waiting on service!")
E       Exception: Timeout reached while waiting on service!

venv/lib/python3.11.../site-packages/pytest_docker/plugin.py:119: Exception

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

codecov bot commented Jul 23, 2025

Bundle Report

Changes will increase total bundle size by 29.53kB (0.13%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.36MB 29.53kB (0.13%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 29.53kB 18.69MB 0.16%

Files in assets/index-*.js:

  • ./src/app/sharedV2/queryBuilder/Condition.tsx → Total Size: 1.98kB

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/ChildLoader.tsx → Total Size: 212 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/hooks/useGlossaryRelatedEntitiesLoader.ts → Total Size: 573 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/ChildrenLoader.tsx → Total Size: 384 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/DomainsTreeView.tsx → Total Size: 1.95kB

  • ./src/app/homeV3/modules/hierarchyViewModule/components/form/sections/relatedEntities/RelatedEntitiesSection.tsx → Total Size: 1.56kB

  • ./src/app/homeV3/modules/hierarchyViewModule/HierarchyViewModule.tsx → Total Size: 2.17kB

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/hooks/useLoader.ts → Total Size: 1.77kB

  • ./src/app/sharedV2/queryBuilder/LogicalFiltersBuilder.tsx → Total Size: 327 bytes

  • ./src/app/sharedV2/queryBuilder/Operands.tsx → Total Size: 1.18kB

  • ./src/app/homeV3/modules/hierarchyViewModule/components/AssetsTreeView.tsx → Total Size: 493 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/glossary/GlossaryTreeView.tsx → Total Size: 1.95kB

  • ./src/app/sharedV2/queryBuilder/QueryBuilder.tsx → Total Size: 2.82kB

  • ./src/app/homeV3/modules/hierarchyViewModule/HierarchyViewModal.tsx → Total Size: 2.56kB

  • ./src/app/sharedV2/queryBuilder/GroupHeader.tsx → Total Size: 2.37kB

  • ./src/app/sharedV2/queryBuilder/OperatorSelect.tsx → Total Size: 623 bytes

  • ./src/app/searchV2/autoCompleteV2/constants.ts → Total Size: 701 bytes

  • ./src/app/sharedV2/queryBuilder/PropertySelect.tsx → Total Size: 575 bytes

  • ./src/alchemy-components/components/Select/utils.ts → Total Size: 2.97kB

  • ./src/app/ingestV2/shared/components/filters/hooks/useOptions.ts → Total Size: 1.17kB

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/hooks/useDomainRelatedEntitiesLoader.ts → Total Size: 424 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/form/constants.ts → Total Size: 228 bytes

Copy link

alwaysmeticulous bot commented Jul 23, 2025

🔴 Meticulous spotted visual differences in 99 of 1300 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit ebb349a. This comment will update as new commits are pushed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly of files in this folder are copies from Saas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy of src/app/entityV2/shared/EntitySearchInput/EntitySearchInput.tsx but redesigned to use components from our components library

@@ -62,7 +62,7 @@ export const getSelectPadding = (size) => {
padding: `${spacing.xxsm} ${spacing.xsm}`,
},
md: {
padding: `${spacing.xsm} ${spacing.xsm}`,
padding: `${spacing.xxsm} ${spacing.xsm}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix to prevent expanding of a select with pill

image

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking really nice! thanks so much for the push here

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 24, 2025
@chriscollins3456 chriscollins3456 merged commit d6d27ae into master Jul 24, 2025
73 of 77 checks passed
@chriscollins3456 chriscollins3456 deleted the vt--ch-586-custom-home-page--add-filters branch July 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants