-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(customHomePage): add related entities filters to hierarchy module #14179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customHomePage): add related entities filters to hierarchy module #14179
Conversation
3cb653e
to
5cbdc56
Compare
5cbdc56
to
71fbdf3
Compare
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
|
Bundle ReportChanges will increase total bundle size by 29.53kB (0.13%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
🔴 Meticulous spotted visual differences in 99 of 1300 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit ebb349a. This comment will update as new commits are pushed. |
7ead0e2
to
de040c9
Compare
408dd0c
to
5ddd380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly of files in this folder are copies from Saas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy of src/app/entityV2/shared/EntitySearchInput/EntitySearchInput.tsx but redesigned to use components from our components library
@@ -62,7 +62,7 @@ export const getSelectPadding = (size) => { | |||
padding: `${spacing.xxsm} ${spacing.xsm}`, | |||
}, | |||
md: { | |||
padding: `${spacing.xsm} ${spacing.xsm}`, | |||
padding: `${spacing.xxsm} ${spacing.xsm}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5ddd380
to
ebb349a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking really nice! thanks so much for the push here
Reducing of vertical size:

Redesign of inputs (redesigned only supportable filters):


Supportable filters:
