feat(ui) Implement deleting of page modules when necessary #14165

chriscollins3456 · 2025-07-22T01:23:31Z

This PR implements actually deleting modules that are removed from a template when we should The only time we should NOT delete a module that we are removing from a template is:

When the module is global and we are not editing the global template
It is one of the default modules (your assets, domains, your subscriptions)

Also fixes an auth bug in the delete endpoint for global template deletion.

alwaysmeticulous · 2025-07-22T01:29:39Z

✅ Meticulous spotted 0 visual differences across 1424 screens tested: view results.

Meticulous evaluated ~10 hours of user flows against your PR.

_{Expected differences? Click here. Last updated for commit 21af36c. This comment will update as new commits are pushed.}

codecov · 2025-07-22T01:30:11Z

Bundle Report

Changes will increase total bundle size by 407 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	22.29MB	407 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	407 bytes	18.65MB	0.0%

Files in assets/index-*.js:

./src/app/homeV3/context/PageTemplateContext.tsx → Total Size: 1.84kB
./src/app/homeV3/modules/constants.ts → Total Size: 1.65kB
./src/app/homeV3/context/hooks/useModuleOperations.ts → Total Size: 10.53kB
./src/app/homeV3/module/components/ModuleMenu.tsx → Total Size: 1.49kB

codecov · 2025-07-22T01:49:42Z

❌ 7 Tests Failed:

Tests completed	Failed	Passed	Skipped
2919	7	2912	10

View the top 2 failed test(s) by shortest run time

com.linkedin.metadata.service.PageModuleServiceTest::testDeletePersonalPageModuleNotCreatedByActor

Stack Traces | 0.017s run time

java.lang.AssertionError: expected [true] but found [false]
	at org.testng.Assert.fail(Assert.java:111)
	at org.testng.Assert.failNotEquals(Assert.java:1578)
	at org.testng.Assert.assertTrue(Assert.java:57)
	at org.testng.Assert.assertTrue(Assert.java:67)
	at com.linkedin.metadata.service.PageModuleServiceTest.testDeletePersonalPageModuleNotCreatedByActor(PageModuleServiceTest.java:329)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:664)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:227)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:957)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:200)
	at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:148)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.testng.TestRunner.privateRun(TestRunner.java:848)
	at org.testng.TestRunner.run(TestRunner.java:621)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:443)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:437)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:397)
	at org.testng.SuiteRunner.run(SuiteRunner.java:336)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1280)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1200)
	at org.testng.TestNG.runSuites(TestNG.java:1114)
	at org.testng.TestNG.run(TestNG.java:1082)
	at org.gradle.api.internal.tasks.testing.testng.TestNGTestClassProcessor.runTests(TestNGTestClassProcessor.java:153)
	at org.gradle.api.internal.tasks.testing.testng.TestNGTestClassProcessor.stop(TestNGTestClassProcessor.java:95)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
	at jdk.proxy2/jdk.proxy2.$Proxy6.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:122)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:72)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

com.linkedin.metadata.service.PageModuleServiceTest::testDeleteGlobalPageModuleWithoutManagePermissionSuccess

Stack Traces | 0.022s run time

java.lang.RuntimeException: Failed to delete PageModule with urn urn:li:dataHubPageModule:test-module
	at com.linkedin.metadata.service.PageModuleService.deletePageModule(PageModuleService.java:174)
	at com.linkedin.metadata.service.PageModuleService.deletePageModule(PageModuleService.java:151)
	at com.linkedin.metadata.service.PageModuleServiceTest.testDeleteGlobalPageModuleWithoutManagePermissionSuccess(PageModuleServiceTest.java:409)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:664)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:227)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:957)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:200)
	at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:148)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.testng.TestRunner.privateRun(TestRunner.java:848)
	at org.testng.TestRunner.run(TestRunner.java:621)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:443)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:437)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:397)
	at org.testng.SuiteRunner.run(SuiteRunner.java:336)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1280)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1200)
	at org.testng.TestNG.runSuites(TestNG.java:1114)
	at org.testng.TestNG.run(TestNG.java:1082)
	at org.gradle.api.internal.tasks.testing.testng.TestNGTestClassProcessor.runTests(TestNGTestClassProcessor.java:153)
	at org.gradle.api.internal.tasks.testing.testng.TestNGTestClassProcessor.stop(TestNGTestClassProcessor.java:95)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
	at jdk.proxy2/jdk.proxy2.$Proxy6.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:200)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:122)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:72)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
Caused by: io.datahubproject.openapi.exception.UnauthorizedException: User is unauthorized to delete global modules.
	at app//com.linkedin.metadata.service.PageModuleService.checkDeleteModulePermissions(PageModuleService.java:202)
	at app//com.linkedin.metadata.service.PageModuleService.checkDeleteModulePermissions(PageModuleService.java:187)
	at app//com.linkedin.metadata.service.PageModuleService.deletePageModule(PageModuleService.java:154)
	... 48 more

View the full list of 1 ❄️ flaky tests

tests.lineage.test_lineage_sdk::test_column_level_lineage_from_schema_field

Flake rate in main: 8.66% (Passed 116 times, Failed 11 times)

Stack Traces | 0.024s run time

test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f7b14a54750>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_column_level_lineage_from_schema_field(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        source_schema_field = SchemaFieldUrn(test_datasets["upstream"].urn, "id")
        column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(source_schema_field), direction="downstream", max_hops=3
        )
    
>       assert len(column_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:203: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

v-tarasevich-blitz-brain

LGTM! Just need to fix some tests

purnimagarg1 · 2025-07-23T15:53:34Z

datahub-web-react/src/app/homeV3/modules/constants.ts

+// keep this in sync with PageModuleService.java
+export const DEFAULT_MODULE_URNS = [
+    'urn:li:dataHubPageModule:your_assets',
+    'urn:li:dataHubPageModule:your_subscriptions',


Do we want to keep subscriptions in OSS here?
Maybe we can remove from both here and PageModuleService for OSS

chriscollins3456 added 2 commits July 21, 2025 20:39

add majority of deleting modules without graphql yet

d4a8cc4

implement deleting for real

128e5e0

github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jul 22, 2025

github-actions bot deployed to datahub-project-web-react (Preview) July 22, 2025 01:28 View deployment

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 22, 2025

fix styling add tests

3b5d63e

github-actions bot deployed to datahub-project-web-react (Preview) July 22, 2025 01:38 View deployment

vercel bot deployed to Preview July 22, 2025 01:52 View deployment

v-tarasevich-blitz-brain self-requested a review July 23, 2025 14:31

v-tarasevich-blitz-brain approved these changes Jul 23, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 23, 2025

chriscollins3456 added 2 commits July 23, 2025 11:40

merge in master, resolve conflicts

373507e

fix tests

21af36c

purnimagarg1 approved these changes Jul 23, 2025

View reviewed changes

github-actions bot deployed to datahub-project-web-react (Preview) July 23, 2025 15:59 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ui) Implement deleting of page modules when necessary #14165

feat(ui) Implement deleting of page modules when necessary #14165

chriscollins3456 commented Jul 22, 2025

Uh oh!

alwaysmeticulous bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 22, 2025 •

edited

Loading

Assets Changed:

Uh oh!

codecov bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

v-tarasevich-blitz-brain left a comment

Uh oh!

purnimagarg1 Jul 23, 2025

Uh oh!

Uh oh!

feat(ui) Implement deleting of page modules when necessary #14165

Are you sure you want to change the base?

feat(ui) Implement deleting of page modules when necessary #14165

Conversation

chriscollins3456 commented Jul 22, 2025

Uh oh!

alwaysmeticulous bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 7 Tests Failed:

Uh oh!

v-tarasevich-blitz-brain left a comment

Choose a reason for hiding this comment

Uh oh!

purnimagarg1 Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alwaysmeticulous bot commented Jul 22, 2025 •

edited

Loading

codecov bot commented Jul 22, 2025 •

edited

Loading

codecov bot commented Jul 22, 2025 •

edited

Loading