Skip to content

fix(applications): fixing application fetching using skipcache #14164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

gabe-lyons
Copy link
Contributor

The application page will be receiving many edit-oriented views, it shouldn't use the search cache.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jul 22, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 22, 2025
Copy link

alwaysmeticulous bot commented Jul 22, 2025

✅ Meticulous spotted 0 visual differences across 1420 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit e96d4f4. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 22, 2025

Bundle Report

Changes will increase total bundle size by 27 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.24MB 27 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 27 bytes 18.61MB 0.0%

Files in assets/index-*.js:

  • ./src/app/applications/ManageApplications.tsx → Total Size: 4.51kB

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-react/src/app/applications/ManageApplications.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@gabe-lyons gabe-lyons merged commit cc4a2b2 into master Jul 25, 2025
34 of 36 checks passed
@gabe-lyons gabe-lyons deleted the fixing-application-fetching-skipcache branch July 25, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants