Skip to content

fix(sdk): always url-encode entity links #13483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

fix(sdk): always url-encode entity links #13483

merged 1 commit into from
May 12, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 10, 2025

This ensures the links are valid even if the urn has a space or /.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 10, 2025
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 10, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 11, 2025
@hsheth2 hsheth2 merged commit 53af032 into master May 12, 2025
63 checks passed
@hsheth2 hsheth2 deleted the url-encode-links branch May 12, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants