Skip to content

fix(ui): enable to edit tag when properties aspect was not present #13470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

anshbansal
Copy link
Collaborator

Tested locally and the UI works

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 9, 2025
Copy link

codecov bot commented May 9, 2025

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2370 6 2364 41
View the top 3 failed test(s) by shortest run time
::tests.cli.delete_cmd.test_timeseries_delete
Stack Traces | 0s run time
.../cli/delete_cmd/test_timeseries_delete.py:27: in <module>
    runner = CliRunner(mix_stderr=False)
E   TypeError: CliRunner.__init__() got an unexpected keyword argument 'mix_stderr'
::tests.cli.user_groups_cmd.test_group_cmd
Stack Traces | 0s run time
.../cli/user_groups_cmd/test_group_cmd.py:14: in <module>
    runner = CliRunner(mix_stderr=False)
E   TypeError: CliRunner.__init__() got an unexpected keyword argument 'mix_stderr'
::tests.cli.user_groups_cmd.test_user_cmd
Stack Traces | 0s run time
.../cli/user_groups_cmd/test_user_cmd.py:14: in <module>
    runner = CliRunner(mix_stderr=False)
E   TypeError: CliRunner.__init__() got an unexpected keyword argument 'mix_stderr'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 9, 2025
Copy link
Collaborator

@skrydal skrydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 9, 2025
@anshbansal
Copy link
Collaborator Author

test_policy_events unrelated to this

@anshbansal anshbansal merged commit dd1b056 into master May 12, 2025
56 of 58 checks passed
@anshbansal anshbansal deleted the ab-2025-may-09-fix-tag-update branch May 12, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants