Skip to content

chore(ingest/snowflake): remove unused query code #13245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 17, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 17, 2025
Copy link

codecov bot commented Apr 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2458 1 2457 47
View the top 1 failed test(s) by shortest run time
tests.unit.test_dagster::test_emit_metadata
Stack Traces | 0.838s run time
Metadata files differ (use `pytest --update-golden-files` to update):
Urn changed, urn:li:dataProcessInstance:0fa780ff92120ac3bf49d0bc070bbda2:
<dataProcessInstanceProperties> changed:
	Value of aspect['customProperties']['execution_plan_snapshot_id'] changed from "0f504b218cd28750ffa8d90a40e9647acba72021" to "834efb7cde870e3a78a6a8249c14733e089b7470".

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Apr 17, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Apr 17, 2025
@hsheth2 hsheth2 merged commit 9f7f3cb into master Apr 21, 2025
86 of 90 checks passed
@hsheth2 hsheth2 deleted the snowflake-dead-code branch April 21, 2025 17:31
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants