Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): look both userinfo and userEditableInfo #11815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Nov 7, 2024

In many cases the title is present on editable info not info. This fixes it by looking at both aspects for analytics page. Otherwise we have a long list of None as title on top users and new users list.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Hello @anshbansal 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants