Skip to content

Commit

Permalink
docs(ingest/lookml): update known discrepancy list (#9941)
Browse files Browse the repository at this point in the history
Co-authored-by: Tamas Nemeth <[email protected]>
  • Loading branch information
hsheth2 and treff7es committed Feb 29, 2024
1 parent 29274c1 commit 0c7ca4c
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 13 deletions.
24 changes: 14 additions & 10 deletions docs-website/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def projectMdFiles = project.fileTree("${project.projectDir}") {
include '**/*.ts'
exclude 'node_modules'
exclude '**/dist/**'
}
}

// Combine GraphQL schemas for documentation.
task generateGraphQLSchema(type: Exec) {
Expand All @@ -68,6 +68,16 @@ task yarnInstall(type: YarnTask) {
} else {
args = ['install']
}

// The node_modules directory can contain built artifacts, so
// it's not really safe to cache it.
outputs.cacheIf { false }

inputs.files(
file('yarn.lock'),
file('package.json'),
)
outputs.dir('node_modules')
}

task yarnGenerate(type: YarnTask, dependsOn: [yarnInstall,
Expand All @@ -94,17 +104,11 @@ task fastReload(type: YarnTask) {
task yarnLint(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) {
inputs.files(projectMdFiles)
args = ['run', 'lint-check']
outputs.dir("dist")
// tell gradle to apply the build cache
outputs.cacheIf { true }
}

task yarnLintFix(type: YarnTask, dependsOn: [yarnInstall]) {
inputs.files(projectMdFiles)
args = ['run', 'lint-fix']
outputs.dir("dist")
// tell gradle to apply the build cache
outputs.cacheIf { true }
}

task serve(type: YarnTask, dependsOn: [yarnInstall] ) {
Expand All @@ -123,11 +127,11 @@ task yarnBuild(type: YarnTask, dependsOn: [yarnLint, yarnGenerate, downloadHisto
outputs.cacheIf { true }
// See https://stackoverflow.com/questions/53230823/fatal-error-ineffective-mark-compacts-near-heap-limit-allocation-failed-java
// and https://github.com/facebook/docusaurus/issues/8329.
// TODO: As suggested in https://github.com/facebook/docusaurus/issues/4765, try switching to swc-loader.
// TODO: As suggested in https://github.com/facebook/docusaurus/issues/4765, try switching to swc-loader or esbuild minification.
if (project.hasProperty('useSystemNode') && project.getProperty('useSystemNode').toBoolean()) {
environment = ['NODE_OPTIONS': '--max-old-space-size=10248']
environment = ['NODE_OPTIONS': '--max-old-space-size=14336']
} else {
environment = ['NODE_OPTIONS': '--max-old-space-size=10248 --openssl-legacy-provider']
environment = ['NODE_OPTIONS': '--max-old-space-size=14336 --openssl-legacy-provider']
}
args = ['run', 'build']

Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion-modules/airflow-plugin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ task cleanPythonCache(type: Exec) {
task buildWheel(type: Exec, dependsOn: [install, cleanPythonCache]) {
commandLine 'bash', '-c',
"source ${venv_name}/bin/activate && set -x && " +
'pip install build && RELEASE_VERSION="\${RELEASE_VERSION:-0.0.0.dev1}" RELEASE_SKIP_TEST=1 RELEASE_SKIP_UPLOAD=1 ./scripts/release.sh'
'uv pip install build && RELEASE_VERSION="\${RELEASE_VERSION:-0.0.0.dev1}" RELEASE_SKIP_TEST=1 RELEASE_SKIP_INSTALL=1 RELEASE_SKIP_UPLOAD=1 ./scripts/release.sh'
}

build.dependsOn install
Expand Down
4 changes: 3 additions & 1 deletion metadata-ingestion/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ task cleanPythonCache(type: Exec) {
"find src tests -type f -name '*.py[co]' -delete -o -type d -name __pycache__ -delete -o -type d -empty -delete"
}
task buildWheel(type: Exec, dependsOn: [install, codegen, cleanPythonCache]) {
commandLine 'bash', '-c', "source ${venv_name}/bin/activate && " + 'uv pip install build && RELEASE_VERSION="\${RELEASE_VERSION:-0.0.0.dev1}" RELEASE_SKIP_TEST=1 RELEASE_SKIP_UPLOAD=1 ./scripts/release.sh'
commandLine 'bash', '-c',
"source ${venv_name}/bin/activate && " +
'uv pip install build && RELEASE_VERSION="\${RELEASE_VERSION:-0.0.0.dev1}" RELEASE_SKIP_TEST=1 RELEASE_SKIP_INSTALL=1 RELEASE_SKIP_UPLOAD=1 ./scripts/release.sh'
}

build.dependsOn install
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/docs/sources/looker/lookml_post.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ If you see messages like `my_file.view.lkml': "failed to load view file: Unable
The first thing to check is that the Looker IDE can validate the file without issues. You can check this by clicking this "Validate LookML" button in the IDE when in development mode.

If that's not the issue, it might be because DataHub's parser, which is based on the [joshtemple/lkml](https://github.com/joshtemple/lkml) library, is slightly more strict than the official Looker parser.
Note that there's currently only one known discrepancy between the two parsers, and it's related to using [multiple colon characters](https://github.com/joshtemple/lkml/issues/82) when defining parameters.
Note that there's currently only one known discrepancy between the two parsers, and it's related to using [leading colons in blocks](https://github.com/joshtemple/lkml/issues/90).

To check if DataHub can parse your LookML file syntax, you can use the `lkml` CLI tool. If this raises an exception, DataHub will fail to parse the file.

Expand Down

0 comments on commit 0c7ca4c

Please sign in to comment.