Update Readme with working git-lfs instructions #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayshrivastava
approved these changes
Nov 3, 2025
gabotechs
requested changes
Nov 3, 2025
README.md
Outdated
|
|
||
| If the above does not work, try the following: | ||
| ```bash | ||
| brew install git-lfs |
There was a problem hiding this comment.
I don't think we can assume that people using this library are on MacOs, and these commands are irrelevant for Linux users.
What I'd do instead is to post a link that points to how to install git-lfs, ideally from an official source, and just let people follow that rather than putting the instruction for all the operating systems here.
There was a problem hiding this comment.
Makes sense, updated. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the instructions in
README.mddidn't work for me, so I've added some new instructions. I also make a note that this step is required for tests to pass, since that wasn't clear to me.