-
Notifications
You must be signed in to change notification settings - Fork 18
Update dim__orgs.sql #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-bigquery
Are you sure you want to change the base?
Update dim__orgs.sql #185
Conversation
9c13863
to
9087b13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ AI Overview
This AI-generated summary of your pull request analyzes your code changes and their potential impact on your data. As this feature is still experimental, please review the details carefully.
-
High-impact changes to user counts: The modification to add
mod(org_id, 2)
to user counts affects 380 rows (48% of the table) and could significantly impact financial reporting in both Looker and Tableau dashboards. Consider whether this artificial inflation of user counts is intended. -
Subscription plan and pricing changes: New logic automatically assigns 'Individual' plan to orgs with 1 or fewer users and sets missing prices to 0, affecting 227 plan entries and 290 pricing values. This has direct implications for financial analysis in downstream assets like the Monthly and Yearly Financials dashboards.
-
Organization ID modifications: The new case statement
mod(org_id, 49) = 0
could subtract 50,000,000 from certain org_ids. This risks breaking referential integrity with other tables that referenceorg_id
and could impact joins in downstream tables likefct__yearly__financials
andsales__sync
.
🕵️ Details
Base branch | Pull Request branch |
master-bigquery (3f06d55) | bigquery-patch-1 (9087b13) |
Tables modified: 1 (details)
- Different: 1
datafold-demo-429713.prod.dim__orgs | ||||||||||||||
Primary keys org_id |
||||||||||||||
master-bigquery | bigquery-patch-1 | |||||||||||||
DIFFERENCES | ||||||||||||||
Exclusive PKs | 12 | 12 | ||||||||||||
3 column(s) with differing values
|
||||||||||||||
View details → | ||||||||||||||
6 potential data app dependencies | ||||||||||||||
Unchanged Attributes
|
Skipped Data Diffs of downstream tables: 3
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tablesdatafold-demo-429713.prod.fct__monthly__financials (table) | Run Data Diff → |
datafold-demo-429713.prod.sales__sync (table) | Run Data Diff → |
datafold-demo-429713.prod.fct__yearly__financials (table) | Run Data Diff → |
No description provided.